-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identifiers to detail page #2126 #2127
Conversation
Hmm, I'd prefer to review this on https://stage.lobid.org/,a s usual. @fsteeg, can deploy this? |
Looks fine, but I have some nitpicks wrt the field names and suggest the following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment re. field names
@acka47 I adjusted the labels, should we deploy it straight or check it on test first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
See #2126
I added the URI, the hbz id, zdb id and alma mms id to the detail page.
Is that good or too much?
When working on the details page.
Personally I would also prefer not to list only one but all type and medium statements. See #2017 But I am not sure how to fix this.
lobid-resources/web/app/views/tags/result_doc.scala.html
Lines 79 to 85 in d32db65
Seems only to allow for one, Could you help here @fsteeg
@acka47 could you checkout if this is good for you:
checkout this branch.
Pick one on http://localhost:9000/resources while in VPN.