Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifiers to detail page #2126 #2127

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Add identifiers to detail page #2126 #2127

merged 6 commits into from
Jan 16, 2025

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jan 16, 2025

See #2126

I added the URI, the hbz id, zdb id and alma mms id to the detail page.
Is that good or too much?

When working on the details page.
Personally I would also prefer not to list only one but all type and medium statements. See #2017 But I am not sure how to fix this.

@with_icon(label: String, property: String, fullField: String) = {
@if((doc\property).asOpt[JsValue].isDefined) {
@defining(if(property != "type") { nestedIds(property) } else { singleOrMultiString(property) }){ v =>
<tr><td>@label</td><td><span class="@Lobid.facetIcon(v,fullField)"></span> @Lobid.facetLabel(v,fullField,"")</td></tr>
}
}
}

Seems only to allow for one, Could you help here @fsteeg

@acka47 could you checkout if this is good for you:

checkout this branch.

cd web
sbt run

Pick one on http://localhost:9000/resources while in VPN.

@TobiasNx TobiasNx changed the title Add URI to detail page #2126 Add identifiers to detail page #2126 Jan 16, 2025
@TobiasNx TobiasNx requested a review from acka47 January 16, 2025 10:25
@acka47
Copy link
Contributor

acka47 commented Jan 16, 2025

Hmm, I'd prefer to review this on https://stage.lobid.org/,a s usual. @fsteeg, can deploy this?

@acka47 acka47 removed their assignment Jan 16, 2025
@fsteeg
Copy link
Member

fsteeg commented Jan 16, 2025

@acka47
Copy link
Contributor

acka47 commented Jan 16, 2025

Looks fine, but I have some nitpicks wrt the field names and suggest the following changes:

  • HBZ ID -> hbz-ID
  • ZDB ID -> ZDB-ID
  • ALMA MMS ID -> Alma-MMS-ID

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment re. field names

@fsteeg
Copy link
Member

fsteeg commented Jan 16, 2025

Seems only to allow for one, Could you help here @fsteeg

Pushed in e7d9b9f, deployed to test:

https://test.lobid.org/resources/99371861600706441

@fsteeg fsteeg removed their assignment Jan 16, 2025
@TobiasNx
Copy link
Contributor Author

Seems only to allow for one, Could you help here @fsteeg

Pushed in e7d9b9f, deployed to test:

test.lobid.org/resources/99371861600706441

Thanks. Now shows all. Thanks. It seems that each statement has its own column. But this does not bother me.

@TobiasNx TobiasNx requested a review from acka47 January 16, 2025 11:30
@TobiasNx
Copy link
Contributor Author

@acka47 I adjusted the labels, should we deploy it straight or check it on test first?

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fsteeg
Copy link
Member

fsteeg commented Jan 16, 2025

@TobiasNx TobiasNx merged commit 3b114d2 into master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants