-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add service provider rewards support #663
Conversation
8da38aa
to
0f0a94c
Compare
29651a6
to
4cb076f
Compare
4cb076f
to
5132f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly here, the payer
that we're using to sum data transfer credits burned by a service provider is the b58 text encoding of the carrier's public key and then we're storing a mapping of that public key to the string-entity key (name) of the service provider stored in the mobile config service but is that mapping not available on-chain such that we can just treat the service provider as a "rewardable entity" and look up their entity key from the metadata database the foundation populates?
good question, my understanding at the time was that we needed to add this to our internally managed DB. I dont recall the exact reason but i think it relates to the fact we only have the payer public key and that is not available as a direct translation on the metadata db populated by foundation ? But i may have just misunderstood and my context of the metadata DB is not that great. @bbalser thoughts? |
06a0307
to
fb698b0
Compare
related hip: https://github.com/helium/HIP/blob/main/0087-proportional-service-provider-rewards.md
related proto pr: helium/proto#377