Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Mobile rewarder to allow testing of each reward type, add integration test for each reward type #683

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Refactor Mobile rewarder to allow testing of each reward type, add integration test for each reward type #683

merged 1 commit into from
Jan 12, 2024

Conversation

andymck
Copy link
Contributor

@andymck andymck commented Dec 6, 2023 •
edited
Loading

No description provided.

@andymck andymck changed the title Andymck/service provider rewards plus unallocated plus reward int tests Refactor rewarded to allow testing of each reward type, add integration test for each reward type Dec 6, 2023
@andymck andymck changed the title Refactor rewarded to allow testing of each reward type, add integration test for each reward type Refactor rewarder to allow testing of each reward type, add integration test for each reward type Dec 6, 2023
@andymck andymck changed the title Refactor rewarder to allow testing of each reward type, add integration test for each reward type Refactor Mobile rewarder to allow testing of each reward type, add integration test for each reward type Dec 11, 2023
@andymck andymck mentioned this pull request Dec 11, 2023
Merged
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated branch from 135871e to 1b6b725 Compare December 14, 2023 12:18
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated-plus-reward-int-tests branch from 7c6d0d8 to f351d40 Compare December 14, 2023 16:42
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated branch 3 times, most recently from a688bf7 to bafe0c8 Compare January 5, 2024 11:26
Base automatically changed from andymck/service-provider-rewards-plus-unallocated to main January 5, 2024 11:34
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated-plus-reward-int-tests branch from f351d40 to 36188b4 Compare January 5, 2024 12:24
@andymck andymck marked this pull request as ready for review January 5, 2024 12:51
jeffgrunewald
jeffgrunewald reviewed Jan 5, 2024
View reviewed changes
mobile_config/src/client/mod.rs Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Outdated Show resolved Hide resolved
mobile_verifier/src/rewarder.rs Show resolved Hide resolved
mobile_verifier/tests/common/mod.rs Outdated Show resolved Hide resolved
mobile_verifier/tests/rewarder_mappers.rs Outdated Show resolved Hide resolved
mobile_verifier/tests/rewarder_mappers.rs Outdated Show resolved Hide resolved
mobile_verifier/tests/rewarder_mappers.rs Outdated Show resolved Hide resolved
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated-plus-reward-int-tests branch 2 times, most recently from fe3ddba to dc16859 Compare January 10, 2024 13:56
@andymck andymck force-pushed the andymck/service-provider-rewards-plus-unallocated-plus-reward-int-tests branch from ee3f21d to cd4c646 Compare January 10, 2024 14:57
@andymck andymck merged commit 76ccb5d into main Jan 12, 2024
1 check passed
@andymck andymck deleted the andymck/service-provider-rewards-plus-unallocated-plus-reward-int-tests branch January 12, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffgrunewald jeffgrunewald jeffgrunewald approved these changes

@bbalser bbalser bbalser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andymck @bbalser @jeffgrunewald