Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryConfig and TimeoutConfig in file_store #911

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

kurotych
Copy link
Member

When a connection problem occurs, downloading a file from AWS hangs.
Add the ability to configure timeout and retry policies in the file_store.

@kurotych kurotych marked this pull request as ready for review December 10, 2024 14:44
@michaeldjeffrey
Copy link
Contributor

Can we get these added to Settings as well so calls to FileStore::from_settings can pick them up?

@kurotych
Copy link
Member Author

Can we get these added to Settings as well so calls to FileStore::from_settings can pick them up?

I think we can but should we?
I can't just add TimeoutConfig and RetryConfig structs into Settings because the Settings type is directly mapped to the config file and I'm not sure how much and what exact config parameters from these two aws configs should I include to Settings. Also, after I include them we should start to support these config parameters (with backward compatibilities). I think we shouldn't hurry in this case.

@kurotych kurotych merged commit aa58a79 into main Dec 13, 2024
17 checks passed
@kurotych kurotych deleted the file-store-timeout branch December 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants