Update Service Provider Promotions for updated flow #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaeldjeffrey
commented
Oct 17, 2024
michaeldjeffrey
commented
- Remove promotion_reward_v1 messages and reports
- Remove promotion_fund_v1 messages and reports
- Simplify promotion_reward for NFT usage
- Add endpoint to mobile-config for listing all service provider promotions
- Add Promotion Reward as MobileRewardShare type
- Write service provider promotions in mobile rewards manifest
michaeldjeffrey
requested review from
macpie,
andymck,
bbalser and
jeffgrunewald
michaeldjeffrey
force-pushed
the
mj/sp-promotions-v2
branch
2 times, most recently
from
4f50a18 to
a8d299d
Compare
- Remove promotion_reward_v1 messages and reports - Remove promotion_fund_v1 messages and reports - Simplify promotion_reward for NFT usage - Add endpoint to mobile-config for listing all service provider promotions - Add Promotion Reward as MobileRewardShare type - Write service provider promotions in mobile rewards manifest
michaeldjeffrey
force-pushed
the
mj/sp-promotions-v2
branch
from
1538366 to
47d19aa
Compare
bbalser
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.