Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong property types issue #970

Merged
merged 22 commits into from
Feb 4, 2025
Merged

Wrong property types issue #970

merged 22 commits into from
Feb 4, 2025

Conversation

Abhijeet-Bentley
Copy link
Contributor

@Abhijeet-Bentley Abhijeet-Bentley commented Jan 17, 2025 •
edited
Loading

itwinjs-core: iTwin/itwinjs-core#7599

  • Added tests to check for code's behaviour if wrong property tags are encountered
  • Expected behavior on encountering wrong property tag:
  1. Older version: Default to string
  2. Current/Latest version: Throws ERROR
  3. Future version: Default to string
  • Added code fix which takes care of all above scenarios.

@Abhijeet-Bentley Abhijeet-Bentley self-assigned this Jan 17, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Abhijeet-Bentley Abhijeet-Bentley changed the title iModel Native/wrong property tags issue Wrong property tags issue Jan 20, 2025
@Abhijeet-Bentley Abhijeet-Bentley mentioned this pull request Jan 24, 2025
Merged
@Abhijeet-Bentley Abhijeet-Bentley marked this pull request as ready for review January 28, 2025 11:53
@Abhijeet-Bentley Abhijeet-Bentley linked an issue Jan 29, 2025 that may be closed by this pull request
Identify the issue when a wrong property tag is used iTwin/itwinjs-core#7473
Closed
@iTwin iTwin deleted a comment from azure-pipelines bot Jan 29, 2025
@Abhijeet-Bentley
Copy link
Contributor Author

/azp run imodel-native

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Abhijeet-Bentley Abhijeet-Bentley changed the title Wrong property tags issue Wrong property types issue Jan 30, 2025
@iTwin iTwin deleted a comment from azure-pipelines bot Jan 30, 2025
@Abhijeet-Bentley
Copy link
Contributor Author

/azp run imodel-native

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Abhijeet-Bentley
Copy link
Contributor Author

/azp run imodel-native

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Abhijeet-Bentley Abhijeet-Bentley enabled auto-merge (squash) February 4, 2025 04:44
@Abhijeet-Bentley Abhijeet-Bentley merged commit a1da902 into main Feb 4, 2025
19 checks passed
@Abhijeet-Bentley Abhijeet-Bentley deleted the abhi/wrong-property-tags-issue branch February 4, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschili rschili rschili approved these changes

@ColinKerr ColinKerr ColinKerr approved these changes

@RohitPtnkr1996 RohitPtnkr1996 RohitPtnkr1996 approved these changes

@akshay05n akshay05n Awaiting requested review from akshay05n

@naveedkhan8067 naveedkhan8067 Awaiting requested review from naveedkhan8067

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@c-macdonald c-macdonald Awaiting requested review from c-macdonald c-macdonald is a code owner

@khanaffan khanaffan Awaiting requested review from khanaffan khanaffan is a code owner

@pmconne pmconne Awaiting requested review from pmconne pmconne is a code owner

Assignees

@Abhijeet-Bentley Abhijeet-Bentley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identify the issue when a wrong property tag is used
6 participants
@Abhijeet-Bentley @CLAassistant @pmconne @rschili @ColinKerr @RohitPtnkr1996