Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and documentation for wrong property tags issue #7599

Merged
merged 30 commits into from
Feb 4, 2025

Conversation

Abhijeet-Bentley
Copy link
Contributor

@Abhijeet-Bentley Abhijeet-Bentley commented Jan 24, 2025

imodel-native: iTwin/imodel-native#970

  • Added tests for checking behavior of wrong property tags in an ECXml schema.
  • Added documentation clearly mentioning what behavior (in this scenario) to be expected across versions.

@Abhijeet-Bentley Abhijeet-Bentley marked this pull request as ready for review January 28, 2025 12:03
Copy link
Contributor

@naveedkhan8067 naveedkhan8067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you have renamed the HandlingUnknownSchemaElements.md, its references should also be updated. For example in IModelDb.md:

From:

To know more about how these unknown elements are handled, refer to [Handling Unknown Schema Elements](./HandlingUnknownSchemaElements.md)

To something like:

To know more about how these unknown elements are handled, refer to [Handling Unknown And Wrong Schema Elements For Newer Versions](./HandlingUnknownAndWrongSchemaElementsForNewerVersions.md)

@Abhijeet-Bentley Abhijeet-Bentley requested a review from a team as a code owner January 29, 2025 12:38
@Abhijeet-Bentley Abhijeet-Bentley linked an issue Jan 29, 2025 that may be closed by this pull request
@Abhijeet-Bentley Abhijeet-Bentley merged commit 8a71d09 into master Feb 4, 2025
14 of 15 checks passed
@Abhijeet-Bentley Abhijeet-Bentley deleted the abhi/wrong-property-tags-testing branch February 4, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify the issue when a wrong property tag is used
7 participants