-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(google-auth): use workload identity federation instead of json #10342
ci(google-auth): use workload identity federation instead of json #10342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Still working on getting approvals to enable this in our ibis-gbq test project.
@tswast Should we just give this a go and merge it? |
ba0cee5
to
620bd00
Compare
Sorry, I misspoke at PyData NYC. Looks like I'm still waiting for approval on one more internal change (issue 375475414 for Googlers' reference) before this can work. |
@tswast Any updates here? |
Thanks for the reminder. I'm still waiting on a thumbs up from our security team. I think I went through the right process, but it's been stuck on the last LGTM for a couple months now. 😭 I'll ping them again today. Maybe I can get another reviewer assigned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but consider resolving the comments on .github/workflows/ci-data.yml
before merging.
56427cb
to
7d71163
Compare
Co-authored-by: Tim Sweña (Swast) <[email protected]>
7d71163
to
8229554
Compare
@tswast Thanks for pushing this through, merging on green! |
@tswast It looks like two tests are failing on Can you help debug the permissions here? |
Looks like step 5 here might be required (giving permissions to specific cloud resources). |
Thanks for the heads up. Taking a look now. Step 5 does have a concerning warning, which I wonder if applies in this case?
For example, the failure to read |
Thanks. If it's helpful, writing data to a bucket (the benchmark data upload) is working, so accessing a bucket directly is not a problem. Just to clarify, from my POV I see two things that might be an issue:
|
If you can't find anything in the next few business days, we can xfail those tests until we understand whether there's an issue. |
I tried out GitHub Actions on another repo (tswast/code-snippets#3) to see if I could reproduce the BigQuery + JS library failure, but I was able to call I suspect it might be a permission issue rather than a BigQuery bug with such credentials. I'll try to take a look at the ibis setup a bit more next week. |
No description provided.