Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(google-auth): use workload identity federation instead of json #10342

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
project_id: "ibis-gbq"
workload_identity_provider: "${{ vars.WIF_PROVIDER_NAME }}"

- uses: google-github-actions/setup-gcloud@v2

Expand Down
15 changes: 9 additions & 6 deletions .github/workflows/ibis-backends-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ on:
types:
- labeled

permissions:
# this allows extractions/setup-just to list releases for `just` at a higher
# rate limit while restricting GITHUB_TOKEN permissions elsewhere
contents: read

env:
FORCE_COLOR: "1"
SQLALCHEMY_WARN_20: "1"
Expand Down Expand Up @@ -79,6 +74,13 @@ jobs:
key: snowpark
extras:
- --extra snowflake
# this allows extractions/setup-just to list releases for `just` at a higher
# rate limit while restricting GITHUB_TOKEN permissions elsewhere
permissions:
contents: "read"
# required for GCP workload identity federation
id-token: "write"

steps:
- name: checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -126,7 +128,8 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
project_id: "ibis-gbq"
workload_identity_provider: "${{ vars.WIF_PROVIDER_NAME }}"

- name: setup databricks credentials
if: matrix.backend.name == 'databricks'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ibis-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
project_id: "ibis-gbq"
workload_identity_provider: "${{ vars.WIF_PROVIDER_NAME }}"

- uses: google-github-actions/setup-gcloud@v2

Expand Down
Loading