Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate base64 from workspace Cargo.toml #1085

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1084


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf82f2a) 66.81% compared to head (d173f7e) 66.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files         204      204           
  Lines       20437    20437           
=======================================
  Hits        13654    13654           
  Misses       6783     6783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit 3b260e2 into main Feb 9, 2024
16 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/fix-base64-resolution branch February 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential dependency resolution issue with base64
2 participants