-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export public APIs in top-level package #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #63 |
This pull request has merge conflicts that must be resolved before it can be |
markmc
reviewed
Jul 3, 2024
Export `SDG`, `GenerateException`, and `generate_data()` in the top-level package name. Add notes to `generate_data` and `GenerateException` that the function and class are part of the public API. Signed-off-by: Christian Heimes <[email protected]>
Adding to `instructlab.sdg`: - `Block` - `EmptyDatasetError` - `FilterByValueBlockError` - `Pipeline` - `PipelineConfigParserError` - `PipelineContext` - `SIMPLE_PIPELINES_PACKAGE` - `FULL_PIPELINES_PACKAGE` Signed-off-by: Mark McLoughlin <[email protected]>
Adding to `instructlab.sdg`: - `CombineColumnsBlock` - `ConditionalLLMBlock` - `FilterByValueBlock` - `ImportBlock` - `LLMBlock` - `SamplePopulatorBlock` - `SelectorBlock` Signed-off-by: Mark McLoughlin <[email protected]>
russellb
approved these changes
Jul 16, 2024
I should have rebased this before merging. It looks like it broke CI. I'll submit a follow-up fix for that. |
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
…actions/rojopolis/spellcheck-github-actions-0.37.0 Bump rojopolis/spellcheck-github-actions from 0.36.0 to 0.37.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63 and #30