Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export public APIs in top-level package #73

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Jul 3, 2024

Fixes #63 and #30

8f014b0 Export public APIs in top-level package
35fe7ee Export more public APIs in top-level package
40b45ad Export more public APIs in top-level package
commit 8f014b0a6960aab78d6b3879eed8d61ba5ab7e16

    Export public APIs in top-level package
    
    Export `SDG`, `GenerateException`, and `generate_data()` in the
    top-level package name. Add notes to `generate_data` and
    `GenerateException` that the function and class are part of the public
    API.
    
commit 35fe7ee65b6e0e2db1ce2fb7d0a4bb1c7f6ba280

    Export more public APIs in top-level package
    
    Adding to `instructlab.sdg`:
    
    - `Block`
    - `EmptyDatasetError`
    - `FilterByValueBlockError`
    - `Pipeline`
    - `PipelineConfigParserError`
    - `PipelineContext`
    - `SIMPLE_PIPELINES_PACKAGE`
    - `FULL_PIPELINES_PACKAGE`    
commit 40b45ad8196087fda02887a9257769d285c7302a
    Export more public APIs in top-level package
    
    Adding to `instructlab.sdg`:
    
    - `CombineColumnsBlock`
    - `ConditionalLLMBlock`
    - `FilterByValueBlock`
    - `ImportBlock`
    - `LLMBlock`
    - `SamplePopulatorBlock`
    - `SelectorBlock`

@markmc
Copy link
Contributor

markmc commented Jul 3, 2024

See #63

@mergify mergify bot added the needs-rebase label Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @tiran please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@markmc markmc added this to the 0.1.3 milestone Jul 15, 2024
tiran and others added 3 commits July 16, 2024 13:56
Export `SDG`, `GenerateException`, and `generate_data()` in the
top-level package name. Add notes to `generate_data` and
`GenerateException` that the function and class are part of the public
API.

Signed-off-by: Christian Heimes <[email protected]>
Adding to `instructlab.sdg`:

- `Block`
- `EmptyDatasetError`
- `FilterByValueBlockError`
- `Pipeline`
- `PipelineConfigParserError`
- `PipelineContext`
- `SIMPLE_PIPELINES_PACKAGE`
- `FULL_PIPELINES_PACKAGE`

Signed-off-by: Mark McLoughlin <[email protected]>
Adding to `instructlab.sdg`:

- `CombineColumnsBlock`
- `ConditionalLLMBlock`
- `FilterByValueBlock`
- `ImportBlock`
- `LLMBlock`
- `SamplePopulatorBlock`
- `SelectorBlock`

Signed-off-by: Mark McLoughlin <[email protected]>
@mergify mergify bot removed the needs-rebase label Jul 16, 2024
@markmc markmc requested a review from russellb July 16, 2024 14:25
@russellb russellb merged commit b0b8096 into instructlab:main Jul 16, 2024
11 checks passed
@russellb
Copy link
Member

I should have rebased this before merging. It looks like it broke CI. I'll submit a follow-up fix for that.

jwm4 pushed a commit to jwm4/sdg that referenced this pull request Dec 13, 2024
…actions/rojopolis/spellcheck-github-actions-0.37.0

Bump rojopolis/spellcheck-github-actions from 0.36.0 to 0.37.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-organize API exports
3 participants