Handle type conversion errors in FilterByValueBlock

[russellb]

97d3fcd filterblock: Don't break when filtering on unexpected data
111711f Add unit tests for sdg.filterblock

commit 97d3fcd
Author: Russell Bryant [email protected]
Date: Wed Jul 3 19:53:23 2024 -0400

filterblock: Don't break when filtering on unexpected data

The previous code in this block did filtering assuming that all
samples had a value that was correct for the type. For example, when
filtering on an integer value, it assumed every row had a valid
integer, where it may instead have garbage.

This change introduces a new helper, _convert_dtype(), which properly
handles this condition. When the conversion fails on a `ValueError`
exception, it treats it as `None` instead of allowing the exception to
be raised up to the caller.

The fix was authored by Shiv in PR #72. I only pulled it out into a
standalone commit.

Signed-off-by: Russell Bryant <[email protected]>
Co-authored-by: shiv <[email protected]>

commit 111711fa419b53e2f31b63bcb91f829eacd55548
Author: Russell Bryant [email protected]
Date: Wed Jul 3 19:56:45 2024 -0400

Add unit tests for sdg.filterblock

This new file introduces some unit tests for the filterblock module.
A previous commit introduced a bug fix to ensure that unexpected data
does not cause this block to break. These tests exercise those fixes.
The tests introduced here will run automatically in CI and help ensure
that the problem does not reoccur.

Signed-off-by: Russell Bryant <[email protected]>

[russellb]

I posted this as part of a discussion thread here: #72 (comment)

[markmc]

Great, very clear. Well done on adding tests. lgtm

[russellb]

CI is passing, it was approved previously as part of #72, and @markmc reviewed this version that split it out and added tests, so I'm going to merge