This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Recover Jason state after reconnection (#47, #27) #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
…/medea into 47-client-state-restoring
FCM
|
# Conflicts: # src/signalling/room.rs
16 tasks
16 tasks
10e5ade
to
39716ed
Compare
Resolved in #167 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47
Part of #27
Synopsis
When server tries to send an
Event
to a Web Client with closedRpcConnection
Event
wouldn't be sent or saved. In the current implementation, on sendingEvent
with closedRpcConnection
will be printed error log message.Solution
Create observable
Room
snapshot at the Web Client side which will be updated by Media ServerEvent
s. When observableRoom
snapshot updates then real state should be updated. All updates will be performed only on this snapshot update.Event
s shouldn't update real state, but should update observableRoom
snapshot.When Web Client reconnects to the server - server should send to the Web Client
Event::RestoreState
with a current Media Server's state. Web Client should set this snapshotand based on this new snapshot, real state should be updated.
This PR implements only Web Client state restoring with
Event
s which server should send but couldn't do it because lost RPC connection. Client's state restoring implementation will have minor changes in the next PR.Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed