Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFC][Doc] Update sycl_ext_intel_device_info backend limitations #16792

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

KseniyaTikhomirova
Copy link
Contributor

SYCL_ENABLE_PCI is deprecated here 2d12863. Remove it as requirement for device info query.
Remove statement that some device info is supported on L0 only if there is at least one another backend that could return it. (mostly it is L0 +hip/cuda).

@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner January 27, 2025 15:22
@KseniyaTikhomirova
Copy link
Contributor Author

@intel/dpcpp-specification-reviewers
hello, could you please provide guidance - should I specify explicitly all backends where ext device info is supported now or remove it and let user check it via aspect::* query. I submitted the second option for now. Although I am ready to redo it.

@gmlueck
Copy link
Contributor

gmlueck commented Jan 28, 2025

@intel/dpcpp-specification-reviewers hello, could you please provide guidance - should I specify explicitly all backends where ext device info is supported now or remove it and let user check it via aspect::* query. I submitted the second option for now. Although I am ready to redo it.

It's better to take out the wording about which backend support each query. Users should check the aspect. It looks like you have mostly done this already, but there are some that you did not remove. Is there a reason these remain?

@KseniyaTikhomirova
Copy link
Contributor Author

KseniyaTikhomirova commented Jan 29, 2025

@intel/dpcpp-specification-reviewers hello, could you please provide guidance - should I specify explicitly all backends where ext device info is supported now or remove it and let user check it via aspect::* query. I submitted the second option for now. Although I am ready to redo it.

It's better to take out the wording about which backend support each query. Users should check the aspect. It looks like you have mostly done this already, but there are some that you did not remove. Is there a reason these remain?

Yes, I left them since they are still relevant and info is supported on L0 only. Should I left all backend mentions then?

@gmlueck
Copy link
Contributor

gmlueck commented Jan 29, 2025

Yes, I left them since they are still relevant and info is supported on L0 only. Should I left all backend mentions then?

Yes, it would be better to remove all mention of the backends that support each query. Applications should really use the aspects instead.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova
Copy link
Contributor Author

Yes, I left them since they are still relevant and info is supported on L0 only. Should I left all backend mentions then?

Yes, it would be better to remove all mention of the backends that support each query. Applications should really use the aspects instead.

done in 0620cdb

@againull againull merged commit 19d54ff into intel:sycl Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants