Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use golangci-lint for code static analysis #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

feat: use golangci-lint for code static analysis

528dbb8
Select commit
Loading
Failed to load commit list.
Open

feat: use golangci-lint for code static analysis #797

feat: use golangci-lint for code static analysis
528dbb8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2025 in 1s

60.54% (+0.02%) compared to 8ca0ca2

View this Pull Request on Codecov

60.54% (+0.02%) compared to 8ca0ca2

Details

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (8ca0ca2) to head (528dbb8).

Files with missing lines Patch % Lines
gateway/serve_http_content.go 25.00% 1 Missing and 2 partials ⚠️
files/util.go 66.66% 1 Missing ⚠️
filestore/fsrefstore.go 0.00% 1 Missing ⚠️
gateway/backend_car_files.go 0.00% 1 Missing ⚠️
ipld/unixfs/unixfs.go 0.00% 1 Missing ⚠️
routing/http/types/json/responses.go 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   60.51%   60.54%   +0.02%     
==========================================
  Files         245      245              
  Lines       31132    31131       -1     
==========================================
+ Hits        18840    18847       +7     
+ Misses      10615    10611       -4     
+ Partials     1677     1673       -4     
Files with missing lines Coverage Δ
bitswap/bitswap.go 69.13% <ø> (ø)
bitswap/client/internal/getter/getter.go 81.81% <ø> (ø)
bitswap/client/internal/peermanager/peermanager.go 91.85% <ø> (ø)
...wap/client/internal/peermanager/peerwantmanager.go 88.50% <ø> (-0.04%) ⬇️
...tswap/client/internal/session/sessionwantsender.go 97.65% <ø> (+0.70%) ⬆️
...l/sessioninterestmanager/sessioninterestmanager.go 100.00% <ø> (ø)
...p/client/internal/sessionmanager/sessionmanager.go 100.00% <ø> (ø)
.../internal/sessionpeermanager/sessionpeermanager.go 100.00% <ø> (ø)
bitswap/client/wantlist/wantlist.go 90.62% <ø> (ø)
bitswap/message/message.go 83.87% <100.00%> (ø)
... and 62 more

... and 5 files with indirect coverage changes