GlassFish runner for the Pages TCK #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Tijms <[email protected]>
scottmarlow
reviewed
Jun 12, 2024
| <glassfish.home>${glassfish.root}/glassfish8</glassfish.home> | ||
|
|
||
| <!-- Print the content of the deployed archives --> | ||
| <pages.tck.archive.print>true</pages.tck.archive.print> |
There was a problem hiding this comment.
Nice feature which I assume helps when checking if your custom (vendor supplied) deployment descriptors were added).
There was a problem hiding this comment.
Although I just noticed I did leave out the implementation code 🫣 But can add it back in an update.
scottmarlow
approved these changes
Jun 12, 2024
Signed-off-by: Arjan Tijms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against GF 8.0.0-M6 and the released Pages 4.0.0 TCK: