-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save complex OS-level I/O to know the CPU topology #216
base: main
Are you sure you want to change the base?
Conversation
threadStatusOffset = unsafe.arrayBaseOffset(long[].class) + pad; | ||
queueSizeOffset = unsafe.arrayBaseOffset(long[].class) + pad * 2; | ||
} else { | ||
unsharedTaskNodesSize = numUnsharedObjects; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmlloyd we have no coverage for this unless we run our test suite with -XX:ActiveProcessorCount=1
so please take a look if I did something wrong
This PR will conflict with #215 so we should coordinate somehow. |
since is a small change @dmlloyd here, feel free to cp into your branch without authoring me ❤️ |
Could we take it a step further? |
The library exists to be used. I'd rather change the logic of the library so that it assumes a reasonable cache line size (perhaps based on something that is faster to ascertain, or just with a sane default) and allows a system property override (with values of, for example, |
I vote for having a sane default and having people opt-in to more complex handling as:
|
@dmlloyd do you think we can make this one to slip in first? So we can take our time into verifying that Unsafe-less we don't regress in runtime perf too - not just RSS? 🙏 |
I think we should fix this only in |
smallrye/smallrye-common#389 is a simply way to do that |
This is related smallrye/smallrye-common#370 since
smallrye-common
exposesCacheInfo
as a public API and dropping it can impact existing users - while doing it here, won't impact anyone.The benefits are quarkusio/quarkus#45436