Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slugified status and error codes for display code and error status #15

Merged
merged 9 commits into from
Jun 9, 2024
Merged

Use slugified status and error codes for display code and error status #15

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
059a375
Slugify API boiler status and error codes
jbouwh Jun 7, 2024
6394a33
Correct capital
jbouwh Jun 8, 2024
42fed26
replace space
jbouwh Jun 8, 2024
4336ded
rename to cv_temperature_too_high
jbouwh Jun 8, 2024
49f39e6
Ensure the default value for deplay_text is slugified too
jbouwh Jun 8, 2024
4c3e41f
Merge branch 'master' into slug-status-codes
jbouwh Jun 8, 2024
8ebb114
Use IntEnum
jbouwh Jun 8, 2024
3c7a5ba
Simplify properties
jbouwh Jun 9, 2024
1bd793f
Correct return type for display_text propery
jbouwh Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions incomfortclient/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,41 +32,41 @@
# key label: displ_code
DISPLAY_CODES: list[int, str] = {
0: "opentherm",
15: "boiler ext.",
15: "boiler_ext",
24: "frost",
37: "central heating rf",
51: "tapwater int.",
37: "central_heating_rf",
51: "tapwater_int",
85: "sensortest",
102: "central heating",
102: "central_heating",
126: "standby",
153: "postrun boiler",
153: "postrun_boiler",
170: "service",
204: "tapwater",
231: "postrun ch",
240: "boiler int.",
231: "postrun_ch",
240: "boiler_int",
255: "buffer",
}
jbouwh marked this conversation as resolved.
Show resolved Hide resolved
FAULT_CODES: list[int, str] = {
0: "Sensor fault after self check",
1: "Temperature too high",
2: "S1 and S2 interchanged",
4: "No flame signal",
5: "Poor flame signal",
6: "Flame detection fault",
8: "Incorrect fan speed",
10: "Sensor fault S1",
11: "Sensor fault S1",
12: "Sensor fault S1",
13: "Sensor fault S1",
14: "Sensor fault S1",
20: "Sensor fault S2",
21: "Sensor fault S2",
22: "Sensor fault S2",
23: "Sensor fault S2",
24: "Sensor fault S2",
27: "Shortcut outside sensor temperature",
29: "Gas valve relay faulty",
30: "Gas valve relay faulty",
0: "sensor_fault_after_self_check",
1: "temperature_too_high",
2: "s1_and_S2_interchanged",
jbouwh marked this conversation as resolved.
Show resolved Hide resolved
4: "no_flame_signal",
5: "poor_flame_signal",
6: "flame_detection_fault",
8: "incorrect fan_speed",
10: "sensor_fault_s1",
11: "sensor_fault_s1",
12: "sensor_fault_s1",
13: "sensor_fault_s1",
14: "sensor_fault_s1",
20: "sensor_fault_s2",
21: "sensor_fault_s2",
22: "sensor_fault_s2",
23: "sensor_fault_s2",
24: "sensor_fault_s2",
27: "shortcut_outside_sensor temperature",
jbouwh marked this conversation as resolved.
Show resolved Hide resolved
29: "gas_valve_relay_faulty",
30: "gas_valve_relay_faulty",
} # "0.0": "Low system pressure"
jbouwh marked this conversation as resolved.
Show resolved Hide resolved

HEATER_ATTRS: tuple[str] = (
Expand Down Expand Up @@ -349,11 +349,11 @@ async def set_override(self, setpoint: float) -> None:

try:
assert OVERRIDE_MIN_TEMP <= setpoint <= OVERRIDE_MAX_TEMP
except AssertionError:
except AssertionError as exc:
raise ValueError(
"The setpoint is outside of it's valid range, "
f"{OVERRIDE_MIN_TEMP}-{OVERRIDE_MAX_TEMP}."
)
) from exc

url = "data.json?heater={self._heater._heater_idx}"
url += f"&thermostat={int(self.room_no) - 1}"
Expand Down
Loading