Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slugified status and error codes for display code and error status #15

Merged
merged 9 commits into from
Jun 9, 2024

Conversation

jbouwh
Copy link
Owner

@jbouwh jbouwh commented Jun 7, 2024

Context

This PR will change the DISPLAY_CODES and FAULT_CODES string table to have slugified strings. THis is needed to allow localization of the status in Home Assistant.

Breaking Change

As user can have automations based on the status code users should update those or use the numeric code instead.

New display codes are:

{
     0: "opentherm",
    15: "boiler_ext",
    24: "frost",
    37: "central_heating_rf",
    51: "tapwater_int",
    85: "sensortest",
    102: "central_heating",
    126: "standby",
    153: "postrun_boiler",
    170: "service",
    204: "tapwater",
    231: "postrun_ch",
    240: "boiler_int",
    255: "buffer",
}

New fault codes are:

{
    0: "sensor_fault_after_self_check",
    1: "cv_temperature_too_high",
    2: "s1_and_s2_interchanged",
    4: "no_flame_signal",
    5: "poor_flame_signal",
    6: "flame_detection_fault",
    8: "incorrect fan_speed",
    10: "sensor_fault_s1",
    11: "sensor_fault_s1",
    12: "sensor_fault_s1",
    13: "sensor_fault_s1",
    14: "sensor_fault_s1",
    20: "sensor_fault_s2",
    21: "sensor_fault_s2",
    22: "sensor_fault_s2",
    23: "sensor_fault_s2",
    24: "sensor_fault_s2",
    27: "shortcut_outside_sensor_temperature",
    29: "gas_valve_relay_faulty",
    30: "gas_valve_relay_faulty",
}

@jbouwh jbouwh requested a review from zxdavb June 7, 2024 11:16
@jbouwh
Copy link
Owner Author

jbouwh commented Jun 7, 2024

@zxdavb If you like please leave a review as this is a breaking change, as some of the strings change.

@jbouwh jbouwh force-pushed the slug-status-codes branch from e0b9b8b to 8f83a26 Compare June 7, 2024 11:30
@jbouwh jbouwh closed this Jun 7, 2024
@jbouwh jbouwh reopened this Jun 7, 2024
@jbouwh jbouwh force-pushed the slug-status-codes branch 2 times, most recently from c952c47 to ba42d13 Compare June 7, 2024 12:19
@jbouwh jbouwh force-pushed the slug-status-codes branch from ba42d13 to 059a375 Compare June 7, 2024 12:26
@jbouwh jbouwh changed the title Use slugified status and error codes for discplay code and error status Use slugified status and error codes for display code and error status Jun 7, 2024
zxdavb
zxdavb previously requested changes Jun 8, 2024
incomfortclient/__init__.py Outdated Show resolved Hide resolved
incomfortclient/__init__.py Outdated Show resolved Hide resolved
incomfortclient/__init__.py Outdated Show resolved Hide resolved
@jbouwh jbouwh requested a review from zxdavb June 8, 2024 09:56
incomfortclient/__init__.py Outdated Show resolved Hide resolved
incomfortclient/__init__.py Outdated Show resolved Hide resolved
@jbouwh
Copy link
Owner Author

jbouwh commented Jun 9, 2024

Thanks

@jbouwh jbouwh merged commit d3db378 into master Jun 9, 2024
1 check passed
@jbouwh jbouwh deleted the slug-status-codes branch June 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants