-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use slugified status and error codes for display code and error status #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zxdavb If you like please leave a review as this is a breaking change, as some of the strings change. |
jbouwh
force-pushed
the
slug-status-codes
branch
2 times, most recently
from
June 7, 2024 12:19
c952c47
to
ba42d13
Compare
jbouwh
changed the title
Use slugified status and error codes for discplay code and error status
Use slugified status and error codes for display code and error status
Jun 7, 2024
zxdavb
previously requested changes
Jun 8, 2024
joostlek
reviewed
Jun 8, 2024
joostlek
reviewed
Jun 9, 2024
joostlek
approved these changes
Jun 9, 2024
Thanks |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR will change the
DISPLAY_CODES
andFAULT_CODES
string table to have slugified strings. THis is needed to allow localization of the status in Home Assistant.Breaking Change
As user can have automations based on the status code users should update those or use the numeric code instead.
New display codes are:
New fault codes are: