Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_maps] Fix fetch_dock_position #1389

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sktometometo
Copy link
Contributor

Fix Fetch's docking station position wrongly changed by #1381.

@k-okada
Copy link
Member

k-okada commented Sep 29, 2023

.github/workflows/config.yml / ros (noetic, jskrobotics/ros-ubuntu:20.04-pcl, python3-rospkg python3-rospkg-modules) (pull_request) Failing after 12m

The noetic test is expected to fail (that's why it does not 'required'), so if someone confirm this PR, then we're ready to merge.

Regarding the noteic test, see #1390

@sktometometo
Copy link
Contributor Author

@mqcmd196 @Kanazawanaoaki @tkmtnt7000 Could you review this PR?

@mqcmd196
Copy link
Member

Before the PR
image

After the PR
image

And the other spots are reasonable
image

@mqcmd196
Copy link
Member

When checking on my local PC, #1361 was helpful.

Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a comment and I think this PR is OK.

I don't know why this change was made before, since there is no explanation in this code, but I assume that he wanted to define the location just before approaching the dock, rather than the position of the Fetch dock itself.
Perhaps, it may also be good to update this file and to set the Fetch dock position itself.
https://github.com/jsk-ros-pkg/jsk_robot/blob/f08427720dd2e467485aba4717d9779b87f3718e/jsk_fetch_robot/jsk_fetch_startup/scripts/correct_position.py#L21-L24

@k-okada k-okada merged commit 088b186 into jsk-ros-pkg:master Sep 29, 2023
@knorth55
Copy link
Member

knorth55 commented Sep 30, 2023

FYI:
@tkmtnt7000 you are right.
i made the spot not for dock place, but for dock's approach position.
for that reason, i named it as dock-front.
but maybe i misused this spot in some program, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants