Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build and release #77

Merged
merged 5 commits into from
Jan 1, 2025
Merged

Improve build and release #77

merged 5 commits into from
Jan 1, 2025

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Apr 24, 2024

This PR improves the automation:

  • adds Github actions for build and release
  • replace the old setup.py with the new pyproject.toml which integrates with bump-my-version for the release (also it has the advantage to integrate with the requirements.txt so that dependencies are managed in a single place)
  • the release can be done simply by running bump-my-version bump patch, then push the tags, and github action will do the rest.

NOTE: the secret of the project must be added to be able to push on pypi.

@lfoppiano lfoppiano changed the title Improve automation Improve build and release Oct 23, 2024
@lfoppiano
Copy link
Collaborator Author

I've tested on my fork and the release can be done automatically. Once this is merged, is necessary to add the action secret PYPI_API_TOKEN to be able to push on pypy.

I've made a sample test project on pypi: https://pypi.org/project/grobid-client-python-test/ (I will remove it once this is merged)

@lfoppiano
Copy link
Collaborator Author

For the release, is necessary to install bump-my-version

bump-my-version show-bump
0.0.11 ── bump ─┬─ major ─ 1.0.0
                ├─ minor ─ 0.1.0
                ╰─ patch ─ 0.0.12

for releasing

bump-my-version bump [major|minorpatch]

And then

git push
git push --tags

et voilá

@lfoppiano lfoppiano requested a review from kermitt2 October 24, 2024 14:32
@lfoppiano lfoppiano merged commit 9e7b933 into master Jan 1, 2025
6 checks passed
@lfoppiano lfoppiano deleted the automation branch January 1, 2025 09:46
@lfoppiano lfoppiano mentioned this pull request Jan 1, 2025
@kermitt2
Copy link
Owner

kermitt2 commented Jan 1, 2025

Hi Luca,

For leaving setup.py, the readme must be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants