Fix evaluation of is not defined expression #108
Conversation
|
|
||
| @Override | ||
| public Function1<PrototypeFactInstance, Object> asFunction(Prototype prototype) { | ||
| return delegate.asFunction(prototype).andThen( result -> result == Prototype.UNDEFINED_VALUE ? ADMITTED_UNDEFINED_VALUE : result ); |
There was a problem hiding this comment.
This is the main fix and it is necessary to workaround the fact that on the Drools side it prevents any constraint evaluation, returning false, when it meets an UNDEFINED_VALUE. I preferred to avoid modifying Drools and fix the problem only here. However I believe that, with this trick, it is not bad that an undefined value is actually evaluated only for this constraint (which is the only one that we know at the moment where this is necessary) and not for each and every constraint that at that point will have to deal with it for no reason.
| return ExistsField.INSTANCE; | ||
| case ExistsField.NEGATED_EXPRESSION_NAME: | ||
| // IsNotDefinedExpression behaves as an existential not only when used alone | ||
| return ruleContext.getCondition().isSingleCondition() ? ExistsField.INSTANCE : NegatedExistsField.INSTANCE; |
There was a problem hiding this comment.
Here I'm clearly making a distinction between the case when the IsNotDefinedExpression is used alone, when it is evaluated as our not existential operator, or in conjuction with another constraint, when it is simply the negation of IsDefinedExpression.
* Adding isNotDefined test (#105) * Clarify IsNotDefined operator behaviour when used alone (#106) * Fix evaluation of is not defined expression (#108) --------- Co-authored-by: Mario Fusco <[email protected]>
No description provided.