Fix evaluation of is not defined expression #108
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| package org.drools.ansible.rulebook.integration.api.domain.constraints; | ||
|
|
||
| import org.drools.ansible.rulebook.integration.api.domain.RuleGenerationContext; | ||
| import org.drools.ansible.rulebook.integration.api.domain.conditions.ConditionExpression; | ||
| import org.drools.ansible.rulebook.integration.api.rulesmodel.ParsedCondition; | ||
| import org.drools.model.functions.Function1; | ||
| import org.drools.model.prototype.PrototypeExpression; | ||
| import org.drools.model.prototype.PrototypeVariable; | ||
| import org.kie.api.prototype.Prototype; | ||
| import org.kie.api.prototype.PrototypeFactInstance; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.function.BiPredicate; | ||
|
|
||
| import static org.drools.ansible.rulebook.integration.api.domain.conditions.ConditionExpression.map2Expr; | ||
| import static org.drools.model.prototype.PrototypeExpression.thisPrototype; | ||
|
|
||
| public enum NegatedExistsField implements RulebookOperator, ConditionFactory { | ||
|
|
||
| INSTANCE; | ||
|
|
||
| public static final String EXPRESSION_NAME = "IsNotDefinedExpression"; | ||
|
|
||
| private static final Object ADMITTED_UNDEFINED_VALUE = AdmittedUndefinedValue.INSTANCE; | ||
|
|
||
| @Override | ||
| public <T, V> BiPredicate<T, V> asPredicate() { | ||
| return (t, v) -> v == ADMITTED_UNDEFINED_VALUE; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "NEGATED_EXISTS_FIELD"; | ||
| } | ||
|
|
||
| @Override | ||
| public ParsedCondition createParsedCondition(RuleGenerationContext ruleContext, String expressionName, Map<?, ?> expression) { | ||
| PrototypeExpression rightExpression = map2Expr(ruleContext, expression).getPrototypeExpression(); | ||
| return new ParsedCondition(thisPrototype(), this, new PrototypeExpressionWithAdmittedUndefined(rightExpression)); | ||
| } | ||
|
|
||
| private static class PrototypeExpressionWithAdmittedUndefined implements PrototypeExpression { | ||
| private final PrototypeExpression delegate; | ||
|
|
||
| private PrototypeExpressionWithAdmittedUndefined(PrototypeExpression delegate) { | ||
| this.delegate = delegate; | ||
| } | ||
|
|
||
| @Override | ||
| public Function1<PrototypeFactInstance, Object> asFunction(Prototype prototype) { | ||
| return delegate.asFunction(prototype).andThen( result -> result == Prototype.UNDEFINED_VALUE ? ADMITTED_UNDEFINED_VALUE : result ); | ||
|
There was a problem hiding this comment. This is the main fix and it is necessary to workaround the fact that on the Drools side it prevents any constraint evaluation, returning false, when it meets an |
||
| } | ||
|
|
||
| @Override | ||
| public Collection<String> getImpactedFields() { | ||
| return delegate.getImpactedFields(); | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<String> getIndexingKey() { | ||
| return delegate.getIndexingKey(); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression andThen(PrototypeExpression other) { | ||
| return delegate.andThen(other); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasPrototypeVariable() { | ||
| return delegate.hasPrototypeVariable(); | ||
| } | ||
|
|
||
| @Override | ||
| public Collection<PrototypeVariable> getPrototypeVariables() { | ||
| return delegate.getPrototypeVariables(); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression composeWith(BinaryOperation.Operator op, PrototypeExpression right) { | ||
| return delegate.composeWith(op, right); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression add(PrototypeExpression right) { | ||
| return delegate.add(right); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression sub(PrototypeExpression right) { | ||
| return delegate.sub(right); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression mul(PrototypeExpression right) { | ||
| return delegate.mul(right); | ||
| } | ||
|
|
||
| @Override | ||
| public PrototypeExpression div(PrototypeExpression right) { | ||
| return delegate.div(right); | ||
| } | ||
| } | ||
|
|
||
| public static class AdmittedUndefinedValue { | ||
| static final AdmittedUndefinedValue INSTANCE = new AdmittedUndefinedValue(); | ||
| static final UnsupportedOperationException HASHCODE_EXCEPTION = new UnsupportedOperationException(); | ||
|
|
||
| public AdmittedUndefinedValue() { | ||
| } | ||
|
|
||
| public int hashCode() { | ||
| throw HASHCODE_EXCEPTION; | ||
| } | ||
|
|
||
| public boolean equals(Object obj) { | ||
| return false; | ||
| } | ||
|
|
||
| public String toString() { | ||
| return "$AdmittedUndefinedValue$"; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'm clearly making a distinction between the case when the
IsNotDefinedExpressionis used alone, when it is evaluated as ournotexistential operator, or in conjuction with another constraint, when it is simply the negation ofIsDefinedExpression.