kuring-101 FeedbackViewModel unit test 수정, MainDispatcherRule 추가 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kuring-101 작업의 연장선에서 FeedbackViewModelTest 가 fail 나는것을 수정합니다.
변경 사항
추후 대응
testFixture 가 kotlin을 지원할수 있게 되면 MainDispatcherRule을 util 모듈로 이동합니다. (다른 방안으로는 test-util 모듈을 따로 만들거나 이 클래스만 util 모듈의 실제코드로 이동하여 해결하는것도 가능할듯 합니다)