[GSoC] New Interface report_metrics in Python SDK
#2371
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
gaocegege
|
ref issue: #2340 |
There was a problem hiding this comment.
Thank you for adding this @Electronic-Waste!
I added a few comments.
/assign @gaocegege @johnugeorge @tenzen-y
Signed-off-by: Electronic-Waste <[email protected]>
….py to report_metrics.py. Signed-off-by: Electronic-Waste <[email protected]>
|
@andreyvelich I made the following changes as you requested after the meeting yesterday:
Can you take a look when you are free? Thanks a lot! |
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
There was a problem hiding this comment.
Thanks @Electronic-Waste, I just added a few nits.
/assign @johnugeorge @tenzen-y
…w line. Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
There was a problem hiding this comment.
Thank you @Electronic-Waste!
/lgtm
/assign @johnugeorge @tenzen-y
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: add report_metrics. Signed-off-by: Electronic-Waste <[email protected]> * fix: modify the code according to the first review. Signed-off-by: Electronic-Waste <[email protected]> * chore: add validation for metrics value & rename katib_report_metrics.py to report_metrics.py. Signed-off-by: Electronic-Waste <[email protected]> * fix: update import path in __init__.py. Signed-off-by: Electronic-Waste <[email protected]> * fix: delete blank line. Signed-off-by: Electronic-Waste <[email protected]> * fix: update RuntimeError doc string & correct spelling error & add new line. Signed-off-by: Electronic-Waste <[email protected]> * fix: delete blank in the last line. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
What this PR does / why we need it:
I add a new interface
report_metricsin Python SDK. Design details: https://github.com/kubeflow/katib/blob/4161cff0faf7700598489f1fbaa5346b948623e2/docs/proposals/push-based-metrics-collection.md#new-interface-report_metrics-in-python-sdkWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: