Add MPIJob to configurator #203
Conversation
- Fix versions of dependencies - Clean up with go mod tidy - Deleted old clientset that blocks go mod - Modified codegen script to work with go mod
started modifier
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -45,6 +45,7 @@ func (c *Configurator) Run(opt *AppOption) error { | |||
| log.Errorf("Cannot unmarshal config spec: %s", opt.InputParams) | |||
| return err | |||
| } | |||
| log.Printf("%+v", configSpec) | |||
| @@ -59,6 +60,7 @@ func (c *Configurator) Run(opt *AppOption) error { | |||
| // If the namespace in the ManifestModSpec is empty valued, replace it with | |||
| // configurator's own namespace which is same as the workflow. This is for | |||
| // cases when the ManifestModSpec is created before namespace is set. | |||
|
|
|||
| @@ -0,0 +1 @@ | |||
| '{"gen": {"manifestFrom": { "path": "/home/akado2009/go/src/github.com/kubeflow/kubebench/controller/examples/mpi-job.yaml"}}, "mod": {"namespace": "kubebench", "volumes": [{"name": "example"}]}}' | |||
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
/retest |
|
@Akado2009: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Partly addresses: #195
This change is