This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Add MPIJob to configurator #203
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4634350
Fix dependencies and packages
xyhuang 4358a98
added mpijob package
Akado2009 2dec0f9
Condition checker added
Akado2009 4f8af70
modified almoslt done
Akado2009 8b0b14e
added example files
Akado2009 458d75e
return back
Akado2009 23c3bb8
moved to v1alpha1 mpi
Akado2009 9d53c30
removed unsuied files
Akado2009 acf4f78
condition fixed
Akado2009 7761f18
changed for review
Akado2009 39eae9a
Merge remote-tracking branch 'upstream/cleanup' into mpi-support
Akado2009 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
apiVersion: apiextensions.k8s.io/v1beta1 | ||
kind: CustomResourceDefinition | ||
metadata: | ||
name: kubebenchjobs.kubebench.operator | ||
name: kubebenchjobs.kubeflow.org | ||
namespace: kubebench | ||
spec: | ||
group: kubebench.operator | ||
version: v1 | ||
group: kubeflow.org | ||
names: | ||
kind: KubebenchJob | ||
plural: kubebenchjobs | ||
scope: Namespaced | ||
scope: Namespaced | ||
version: v1alpha2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,70 @@ | ||
#uncomment lines | ||
apiVersion: kubebench.operator/v1 | ||
apiVersion: kubeflow.org/v1alpha2 | ||
kind: KubebenchJob | ||
metadata: | ||
name: kubebench-job | ||
namespace: default | ||
namespace: kirill-kubebench | ||
spec: | ||
serviceAccount: default | ||
volumeSpecs: | ||
configVolume: | ||
name: my-config-volume | ||
persistentVolumeClaim: | ||
claimName: kubebench-config-pvc | ||
volumes: | ||
- name: kubebench-config-volume | ||
configMap: | ||
name: kubebench-config-pvc | ||
- name: kubebench-data-volume | ||
persistentVolumeClaim: | ||
claimName: kubebench-data-pvc | ||
managedVolumes: | ||
experimentVolume: | ||
name: my-experiment-volume | ||
name: kubebench-experiment-volume | ||
persistentVolumeClaim: | ||
claimName: kubebench-experiment-pvc | ||
workflowVolume: | ||
name: kubebench-workflow-volume | ||
persistentVolumeClaim: | ||
claimName: kubebench-exp-pvc | ||
# secretSpecs: # optional | ||
# githubTokenSecret: # optional | ||
# secretName: my-github-token-secret | ||
# secretKey: my-github-token-secret-key | ||
# gcpCredentialsSecret: # optional | ||
# secretName: my-gcp-credentials-secret | ||
# secretKey: my-gcp-credentials-secret-key | ||
jobSpecs: | ||
preJob: # optional | ||
container: # optional between "container" and "resource" | ||
name: my-prejob | ||
image: gcr.io/myprejob-image:latest # change it before using | ||
mainJob: # mandatory | ||
resource: # optional between "container" and "resource" | ||
manifestTemplate: | ||
valueFrom: | ||
ksonnet: # optional, more types in the future | ||
name: kubebench-example-tfcnn-with-monitoring | ||
package: kubebench-examples | ||
registry: /kubebench/config/registry/kubebench | ||
manifestParameters: | ||
valueFrom: | ||
path: tf-cnn/tf-cnn-dummy.yaml | ||
createSuccessCondition: createSuccess # optional | ||
createFailureCondition: createFailure # optional | ||
runSuccessCondition: runSuccess # optional | ||
runFailureCondition: runFailure # optional | ||
#other optional fields: "manifest" - string of raw manifest | ||
postJob: # optional | ||
container: # optional between "container" and "resource" | ||
name: my-postjob | ||
image: gcr.io/kubeflow-images-public/kubebench/kubebench-example-tf-cnn-post-processor:3c75b50 | ||
reportSpecs: # optional | ||
csv: # optional | ||
- inputPath: result.json | ||
outputPath: report.csv | ||
claimName: kubebench-workflow-pvc | ||
workflowAgent: | ||
container: | ||
volumeMounts: | ||
- name: kubebench-config-volume | ||
mountPath: /kubebench/config | ||
tasks: | ||
- name: download-data | ||
container: | ||
name: download-dataset | ||
image: kirill-mlperf-download-image:latest | ||
volumeMounts: | ||
- name: kubebench-data-volume | ||
mountPath: /data | ||
options: | ||
mountManagedVolumes: true | ||
autoWatch: | ||
timeout: 5m | ||
autoDelete: true | ||
numCopies: 1 | ||
- name: preprocess-data | ||
container: | ||
name: preprocess-dataset | ||
image: kirill-mlperf-preprocess-image:latest | ||
volumeMounts: | ||
- name: kubebench-data-volume | ||
mountPath: /data | ||
options: | ||
mountManagedVolumes: true | ||
autoWatch: | ||
timeout: 5m | ||
autoDelete: true | ||
numCopies: 1 | ||
- name: run-training | ||
dependencies: [pre-job-1, pre-job-2] | ||
container: | ||
name: run-training | ||
image: kirill-mlperf-training-image:latest | ||
volumeMounts: | ||
- name: kubebench-data-volume | ||
mountPath: /data | ||
options: | ||
mountManagedVolumes: true | ||
autoWatch: | ||
timeout: 5m | ||
autoDelete: true | ||
numCopies: 1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# This file shows how to run multi-node training benchmarks using an MPIJob, | ||
# specifying GPUs explicitly per replica. | ||
apiVersion: kubeflow.org/v1alpha1 | ||
kind: MPIJob | ||
metadata: | ||
name: training-imagenet | ||
spec: | ||
replicas: 3 | ||
template: | ||
spec: | ||
containers: | ||
- image: docker.io/akado2009/kirill-mlperf-training:latest | ||
name: training-imagenet | ||
resources: | ||
limits: | ||
nvidia.com/gpu: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
namespace: kubebench | ||
volumes: | ||
- name: efs | ||
nfs: | ||
server: fs-ab134502.efs.us-west-2.amazonaws.com | ||
path: / | ||
readOnly: true |
18 changes: 0 additions & 18 deletions
18
controller/pkg/client/clientset/versioned/typed/kubebenchjob/v1/doc.go
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
controller/pkg/client/clientset/versioned/typed/kubebenchjob/v1/fake/doc.go
This file was deleted.
Oops, something went wrong.
138 changes: 0 additions & 138 deletions
138
controller/pkg/client/clientset/versioned/typed/kubebenchjob/v1/fake/fake_kubebenchjob.go
This file was deleted.
Oops, something went wrong.
38 changes: 0 additions & 38 deletions
38
...ler/pkg/client/clientset/versioned/typed/kubebenchjob/v1/fake/fake_kubebenchjob_client.go
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this?