test: migrate kubeflow-pipeline-e2e-test to GitHub Actions #10887
Conversation
|
Skipping CI for Draft Pull Request. |
google-oss-prow
bot
requested review from
chensun,
gaoning777,
IronPan,
jlyaoyuli and
zijianjoy
|
/test all |
Signed-off-by: hbelmiro <[email protected]>
hbelmiro
force-pushed
the
kubeflow-pipeline-e2e-test
branch
from
e073e0b to
998a2aa
Compare
hbelmiro
changed the title
|
@chensun can you please take a look? |
.github/workflows/e2e-test.yaml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: kfp-backend-artifacts | ||
| path: /tmp/tmp.*/* |
There was a problem hiding this comment.
minor nitpick, needs a newline EoF.
Signed-off-by: hbelmiro <[email protected]>
|
@hbelmiro: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -38,7 +38,7 @@ func (s *InitializationTest) SetupTest() { | |||
| return | |||
| } | |||
|
|
|||
| err := test.WaitForReady(*namespace, *initializeTimeout) | |||
There was a problem hiding this comment.
Can we keep the namespace parameter? While it always defaults to "kubeflow" in case of KFP standalone deployment, it would be useful in testing multi-tenancy in full kubeflow deployment (though we don't have automated test for it yet).
There was a problem hiding this comment.
Actually, WaitForReady does no longer depend on any namespace since now it invokes localhost:8888.
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| # Common paths | |||
| GITHUB_REPO = 'kubeflow/pipelines' | |||
| BASE_DIR = os.path.join('/python/src/github.com/', GITHUB_REPO) | |||
| BASE_DIR = os.path.abspath('./') | |||
There was a problem hiding this comment.
Possibly something wrong with the path here? I see an error message from https://github.com/kubeflow/pipelines/actions/runs/9468749205/job/26085814220?pr=10887
Config file with the same name not found, use default args:[Errno 2] No such file or directory: '/home/runner/work/pipelines/pipelines/test/sample-test/configs/sequential.config.yaml'
and somehow it didn't fail the test?
There was a problem hiding this comment.
This isn't an error. When the file doesn't exist, the execution falls back to the default config. The file really doesn't exist.
The change in the BASE_DIR variable is because we are no longer running in a container. Instead, we are running locally within the GitHub Actions Runner. The old os.path.join('/python/src/github.com/', GITHUB_REPO) path doesn't exist in the runner.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves: #10866
Description of your changes:
PR to remove the corresponding test from GoogleCloudPlatform/oss-test-infra:
Checklist: