-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate kubeflow-pipeline-e2e-test to GitHub Actions #10887
Merged
google-oss-prow
merged 2 commits into
kubeflow:master
from
hbelmiro:kubeflow-pipeline-e2e-test
Jun 13, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
name: KFP e2e tests | ||
|
||
on: | ||
push: | ||
branches: [master] | ||
|
||
pull_request: | ||
paths: | ||
- '.github/workflows/e2e-test.yaml' | ||
- 'scripts/deploy/github/**' | ||
- 'go.mod' | ||
- 'go.sum' | ||
- 'backend/**' | ||
- 'frontend/**' | ||
- 'proxy/**' | ||
- 'manifests/kustomize/**' | ||
- 'test/**' | ||
|
||
jobs: | ||
integration-test: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Create k8s Kind Cluster | ||
uses: container-tools/kind-action@v2 | ||
with: | ||
cluster_name: kfp | ||
kubectl_version: v1.29.2 | ||
version: v0.22.0 | ||
node_image: kindest/node:v1.29.2 | ||
|
||
- name: Build images | ||
run: ./scripts/deploy/github/build-images.sh | ||
|
||
- name: Deploy KFP | ||
run: ./scripts/deploy/github/deploy-kfp.sh | ||
|
||
- name: Forward API port | ||
run: ./scripts/deploy/github/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888 | ||
|
||
- name: Initialization tests v1 | ||
working-directory: ./backend/test/initialization | ||
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true | ||
|
||
- name: Initialization tests v2 | ||
working-directory: ./backend/test/v2/initialization | ||
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true | ||
|
||
- name: API integration tests v1 | ||
working-directory: ./backend/test/integration | ||
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true | ||
|
||
- name: API integration tests v2 | ||
working-directory: ./backend/test/v2/integration | ||
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true | ||
|
||
- name: Forward Frontend port | ||
run: ./scripts/deploy/github/forward-port.sh "kubeflow" "ml-pipeline-ui" 3000 3000 | ||
|
||
- name: Build frontend integration tests image | ||
working-directory: ./test/frontend-integration-test | ||
run: docker build . -t kfp-frontend-integration-test:local | ||
|
||
- name: Frontend integration tests | ||
run: docker run --net=host kfp-frontend-integration-test:local --remote-run true | ||
|
||
- name: Basic sample tests - sequential | ||
run: pip3 install -r ./test/sample-test/requirements.txt && pip3 install kfp~=2.0 && python3 ./test/sample-test/sample_test_launcher.py sample_test run_test --namespace kubeflow --test-name sequential --results-gcs-dir output | ||
|
||
# Disabled while https://github.com/kubeflow/pipelines/issues/10885 is not resolved | ||
# - name: Basic sample tests - exit_handler | ||
# run: pip3 install -r ./test/sample-test/requirements.txt && pip3 install kfp~=2.0 && python3 ./test/sample-test/sample_test_launcher.py sample_test run_test --namespace kubeflow --test-name exit_handler --results-gcs-dir output | ||
|
||
- name: Collect test results | ||
if: always() | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: kfp-backend-artifacts | ||
path: /tmp/tmp.*/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#!/usr/bin/env bash | ||
|
||
usage() { | ||
echo "Usage: $0 [-q] <KUBEFLOW_NS> <APP_NAME> <LOCAL_PORT> <REMOTE_PORT>" | ||
exit 1 | ||
} | ||
|
||
QUIET=0 | ||
while getopts "q" opt; do | ||
case $opt in | ||
q) QUIET=1 ;; | ||
*) usage ;; | ||
esac | ||
done | ||
shift $((OPTIND -1)) | ||
|
||
if [ $# -ne 4 ]; then | ||
usage | ||
fi | ||
|
||
KUBEFLOW_NS=$1 | ||
APP_NAME=$2 | ||
LOCAL_PORT=$3 | ||
REMOTE_PORT=$4 | ||
|
||
POD_NAME=$(kubectl get pods -n "$KUBEFLOW_NS" -l "app=$APP_NAME" -o jsonpath='{.items[0].metadata.name}') | ||
|
||
if [ $QUIET -eq 1 ]; then | ||
kubectl port-forward -n "$KUBEFLOW_NS" "$POD_NAME" "$LOCAL_PORT:$REMOTE_PORT" > /dev/null 2>&1 & | ||
else | ||
kubectl port-forward -n "$KUBEFLOW_NS" "$POD_NAME" "$LOCAL_PORT:$REMOTE_PORT" & | ||
fi | ||
|
||
# wait for the port-forward | ||
sleep 5 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the namespace parameter? While it always defaults to "kubeflow" in case of KFP standalone deployment, it would be useful in testing multi-tenancy in full kubeflow deployment (though we don't have automated test for it yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
WaitForReady
does no longer depend on any namespace since now it invokeslocalhost:8888
.