Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): modelToCRDTrigger was not including periodic schedule correctly #11475

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

hbelmiro
Copy link
Contributor

This PR fixes the issue where CronSchedule and PeriodicSchedule structs were incorrectly evaluated as non-empty even when their fields were all nil. The issue arose because direct struct comparison with (CronSchedule{}) or (PeriodicSchedule{}) does not account for the semantics of pointer fields being nil, "" or 0.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Dec 19, 2024
@hbelmiro hbelmiro marked this pull request as draft December 19, 2024 19:44
@hbelmiro hbelmiro marked this pull request as ready for review December 19, 2024 19:58
@mprahl
Copy link
Contributor

mprahl commented Dec 20, 2024

/lgtm

Copy link

@mprahl: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@mprahl: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HumairAK
Copy link
Collaborator

/approve

Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's try this again...

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 97acacb into kubeflow:master Dec 20, 2024
34 checks passed
@hbelmiro hbelmiro deleted the fix-trigger branch December 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants