Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix typescript examples for v1 #2136

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 4, 2025

This commit updates the typescript examples to work with the v1 branch. The examples were tested using Node 23 and the --experimental-strip-types flag.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2025
@cjihrig cjihrig changed the title examples: fix kubectl typescript for v1 examples: fix typescript examples for v1 Jan 4, 2025
This commit updates the typescript examples to work with the v1
branch. The examples were tested using Node 23 and the
--experimental-strip-types flag.
@mstruebing
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit feb78d4 into kubernetes-client:main Jan 6, 2025
8 checks passed
@cjihrig cjihrig deleted the ts-examples branch January 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants