Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix typescript examples for v1 #2136

Merged
merged 1 commit into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions examples/typescript/apply/apply-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ const client = k8s.KubernetesObjectApi.makeApiClient(kc);

// update deployment "my-deployment" in namespace "my-namespace" to 3 replicas
const deployment = {
apiVersion: 'apps/v1',
kind: 'Deployment',
metadata: {
name: 'my-deployment',
namespace: 'my-namespace'
},
spec: {
replicas: 3
}
}
apiVersion: 'apps/v1',
kind: 'Deployment',
metadata: {
name: 'my-deployment',
namespace: 'my-namespace',
},
spec: {
replicas: 3,
},
};

client.patch(deployment)
client.patch(deployment);
10 changes: 5 additions & 5 deletions examples/typescript/apply/apply-from-file-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ export async function apply(specPath: string): Promise<k8s.KubernetesObject[]> {
//
// See: https://github.com/kubernetes/kubernetes/issues/97423
const response = await client.patch(spec);
created.push(response.body);
created.push(response);
} catch (err) {
// if the resource doesnt exist then create it
if (err instanceof k8s.HttpError && err.statusCode === 404) {
const response = await client.create(spec);
created.push(response.body);
if (err instanceof k8s.ApiException && err.code === 404) {
const response = await client.create(spec);
created.push(response);
} else {
throw err
throw err;
}
}
}
Expand Down
10 changes: 9 additions & 1 deletion examples/typescript/attach/attach-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,12 @@ const namespace = 'default';
const pod = 'nginx-4217019353-9gl4s';
const container = 'nginx';

attach.attach(namespace, pod, container, process.stdout, process.stderr, null /* stdin */, false /* tty */);
await attach.attach(
namespace,
pod,
container,
process.stdout,
process.stderr,
null /* stdin */,
false /* tty */,
);
4 changes: 2 additions & 2 deletions examples/typescript/cp/cp-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const cp = new k8s.Cp(kc);
const namespace = 'default';
const pod = 'nginx-4217019353-9gl4s';
const container = 'nginx';
const srcPath = '/test.txt';
const srcPath = './test.txt';
const targetPath = '/tmp';

cp.cpFromPod(namespace, pod, container, srcPath, targetPath);
await cp.cpFromPod(namespace, pod, container, srcPath, targetPath);
4 changes: 0 additions & 4 deletions examples/typescript/informer/informer.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import * as k8s from '@kubernetes/client-node';

const kc = new k8s.KubeConfig();

kc.loadFromDefault();

const k8sApi = kc.makeApiClient(k8s.CoreV1Api);

const namespace = 'default';

const listFn = () => k8sApi.listNamespacedPod({ namespace });

const informer = k8s.makeInformer(kc, `/api/v1/namespaces/${namespace}/pods`, listFn);

informer.on('add', (obj: k8s.V1Pod) => {
Expand Down
6 changes: 3 additions & 3 deletions examples/typescript/patch/patch-example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
ResponseContext,
KubeConfig,
createConfiguration,
Configuration,
type Configuration,
ServerConfiguration,
} from '@kubernetes/client-node';
import { PromiseMiddlewareWrapper } from '@kubernetes/client-node/dist/gen/middleware.js';
Expand Down Expand Up @@ -50,7 +50,7 @@ try {
default: kc,
},
});
const podName = res.items[0].metadata?.name;
const podName = res.items[0]?.metadata?.name;
if (podName === undefined) {
throw new Error('Pod name is undefined');
}
Expand All @@ -62,7 +62,7 @@ try {
body: patch,
},
configuration,
)
);

console.log('Patched.');
} catch (err) {
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/simple/example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const k8sApi = kc.makeApiClient(k8s.CoreV1Api);
const namespace = 'default';

const res = await k8sApi.listNamespacedPod({ namespace });
console.log(res.body);
console.log(res);

// Example of instantiating a Pod object.
const pod = {} as k8s.V1Pod;
Loading