-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golangci-lint timeout from 2m to 5m #1571
Bump golangci-lint timeout from 2m to 5m #1571
Conversation
Sometimes golangci-lint timesout when running in CI. Bump the timeout from 2 minutes to 5 minutes to reduce flakey CI failures. ref: https://golangci-lint.run/usage/configuration/#run-configurationhttps://golangci-lint.run/usage/configuration/#run-configuration
Here an example failed CI job, https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_descheduler/1569/pull-descheduler-verify-master/1865066701259804672
|
/kind cleanup |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jklaw90 please review when you have some time. Thanks! |
/lgtm |
Sometimes golangci-lint timesout when running in CI. Bump the timeout from 2 minutes to 5 minutes to reduce flakey CI failures.
ref: https://golangci-lint.run/usage/configuration/#run-configurationhttps://golangci-lint.run/usage/configuration/#run-configuration