Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add istio provider #111

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Add istio provider #111

merged 10 commits into from
Jan 8, 2024

Conversation

dpasiukevich
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add istio provider which does Istio API (Gateway & VirtualService) -> K8S Gateway API conversion

Which issue(s) this PR fixes:

Fixes #100

Does this PR introduce a user-facing change?:

Add support for Istio API conversion to K8S Gateway API

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 27, 2023
@dpasiukevich dpasiukevich marked this pull request as ready for review December 30, 2023 16:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2023
LiorLieberman
LiorLieberman reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome PR!

I finished first round of reviews.

I think we need @howardjohn for the ins and outs of the logic.

Also - as we are now in 2024 - do you mind have another commit that changes only the new files you added to 2024?

/cc @howardjohn

pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/README.md Outdated Show resolved Hide resolved
howardjohn
howardjohn approved these changes Jan 2, 2024
View reviewed changes
Copy link

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

dpasiukevich
dpasiukevich commented Jan 3, 2024
View reviewed changes
Copy link
Member Author

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd addresses all the comments, besides the rewrite filter which would be updated later.

If there's a rewrite in istio.HTTPRoute and it has different match types (prefix and full/regex), then I'd aggregate matches and generate 2 k8sgw.HTTPRoutes (one with Prefix and the other with FullPath) rewrite filter

pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/README.md Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Outdated Show resolved Hide resolved
LiorLieberman
LiorLieberman reviewed Jan 5, 2024
View reviewed changes
pkg/i2gw/providers/istio/README.md Show resolved Hide resolved
pkg/i2gw/providers/istio/README.md Outdated Show resolved Hide resolved
pkg/i2gw/providers/istio/converter.go Show resolved Hide resolved
@LiorLieberman
Copy link
Member

Awesome work!
Thanks for working on this.

/hold

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpasiukevich, howardjohn, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@LiorLieberman
Copy link
Member

Holding because I wanted to let you choose whether you think it is more appropriate to merge this commit with all the commit messages. (then add /label tide/merge-method-merge). Otherwise if you want to robot to squash it, just remove the hold

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@dpasiukevich
Copy link
Member Author

@LiorLieberman thanks! I've kept the commit chain as it's structured finely (only squashed the last commit). Could you re-lgtm?

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@LiorLieberman
Copy link
Member

/label tide/merge-method-merge

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Jan 8, 2024
@LiorLieberman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 742bb82 into kubernetes-sigs:main Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman left review comments

@howardjohn howardjohn howardjohn approved these changes

@mlavacca mlavacca Awaiting requested review from mlavacca

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Istio provider support
4 participants
@dpasiukevich @k8s-ci-robot @LiorLieberman @howardjohn