feat: Folder Explorer as an independent component #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.64% (-0.01% 🔻) |
142/5375 |
| 🔴 | Branches | 2.85% (-0% 🔻) |
101/3541 |
| 🔴 | Functions | 1.51% (-0.01% 🔻) |
27/1784 |
| 🔴 | Lines | 2.52% (-0.01% 🔻) |
133/5272 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / LegacyFolderExplorer.tsx |
0% | 0% | 0% | 0% |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 584f9ce
|
Please check for the title! 😉 |
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
3 times, most recently
from
ee7d897 to
c4ea9e9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
2 times, most recently
from
8254a2a to
0400fa1
Compare
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
0400fa1 to
7e2155e
Compare
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
2 times, most recently
from
e00c2fe to
3ff8d45
Compare
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
3ff8d45 to
584f9ce
Compare
ironAiken2
changed the title
yomybaby
changed the title
yomybaby
requested changes
Jul 16, 2024
yomybaby
requested changes
Jul 16, 2024
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
584f9ce to
59caf59
Compare
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
59caf59 to
1dd4ed1
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.17% (-0.02% 🔻) |
184/5804 |
| 🔴 | Branches | 3.16% (-0.02% 🔻) |
123/3897 |
| 🔴 | Functions | 1.87% (-0.01% 🔻) |
36/1922 |
| 🔴 | Lines | 3.04% (-0.02% 🔻) |
173/5686 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / LegacyFolderExplorer.tsx |
0% | 0% | 0% | 0% |
Test suite run success
64 tests passing in 6 suites.
Report generated by 🧪jest coverage report action from cbf60b0
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
1dd4ed1 to
f17ba0c
Compare
agatha197
requested changes
Jul 31, 2024
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
de52c9c to
6058a7e
Compare
agatha197
requested changes
Jul 31, 2024
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
6058a7e to
c4771b1
Compare
Since the modal is written as a web component, I modified it to set empty the field when the modal opens. |
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
c4771b1 to
da5dd02
Compare
yomybaby
requested changes
Aug 5, 2024
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
da5dd02 to
a4313d5
Compare
agatha197
force-pushed
the
feat/legacy-folder-explorer
branch
from
a4313d5 to
4a4a00b
Compare
yomybaby
force-pushed
the
feat/legacy-folder-explorer
branch
from
4a4a00b to
17cd1e4
Compare
Merge activity
|
### TL;DR This is a task to decouple folder-explorer from storage-list so that folder-explorer can be called and used from anywhere in React Root. ### What changed? The folder explorer that was dependent on `backend-ai-storage-list` has been separated and used inside `LegacyFolderExplorer`, which can be called and used from any part of react root. The API response to get files of a vfolder exists files(for legacy compatibility) and items. In explorer, I changed to using items. Currently, you can use the folder ID passed as a query parameter by passing it as a prop. ### How to test? 1. navigate to the Data & Storage tab. 2. create a folder or open an existing folder. 3. Check the folder explorer modal. The `LegacyFolderExplorer` provides the same functionality as before. I'd appreciate it if you could check if there are any changes I missed compared to the existing modal. ### Why make this change? To improve the usability and functionality of the modal and folder explorer components in the application. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
force-pushed
the
feat/legacy-folder-explorer
branch
from
17cd1e4 to
cbf60b0
Compare
agatha197
pushed a commit
that referenced
this pull request
Aug 20, 2024
### TL;DR After #2529, vFodler share button has disappeared. - restore functionality to retrieve and process allowed vFolder hosts for the current user. - Removed folder explorer event listener which event are not used. ### What changed? - Removed `openFolderExplorer` method and its associated event listeners from `BackendAIData` class. - Restore methods in `BackendAiStorageList` class: - `_getCurrentKeypairResourcePolicy`: Fetches the current keypair's resource policy. - `_getAllowedVFolderHostsByCurrentUserInfo`: Retrieves and processes allowed vFolder hosts for the current user, considering domain, group, and resource policy permissions. - Restore `_viewStateChanged` and `connectedCallback` methods to call `_getAllowedVFolderHostsByCurrentUserInfo`. ### How to test? 1. Navigate to the data view in the Backend.AI interface. 2. Verify that folder explorer functionality still works as expected, despite the removal of the explicit event listener. 3. Create a vfolder 4. Verify that the share button in control column is displayed and works as expected. ### Why make this change? This change improves the efficiency of handling folder explorer actions and provides a more comprehensive way to determine allowed vFolder hosts for the current user. By considering domain, group, and resource policy permissions, the system can now present a more accurate and personalized view of available storage options to each user.
ironAiken2
added a commit
to lablup/backend.ai-docs-webui
that referenced
this pull request
Nov 22, 2024
### This PR is about updating vfolder section for 24.09 **Changes:** - Added a feature description for the new folder creation modal and updated related images. **Related PR:** - lablup/backend.ai-webui#2745 @ironAiken2 - lablup/backend.ai-webui#2529 @ironAiken2 PDF[ko] : [데이터 & 폴더 활용하기 — Backend.AI Web-UI User Guide 24.03 문서.pdf](https://github.com/user-attachments/files/17488475/Backend.AI.Web-UI.User.Guide.24.03.pdf) PDF[en] : [Handling Data & Storage Folders — Backend.AI Web-UI User Guide 24.03 documentation.pdf](https://github.com/user-attachments/files/17488477/Handling.Data.Storage.Folders.Backend.AI.Web-UI.User.Guide.24.03.documentation.pdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is a task to decouple folder-explorer from storage-list so that folder-explorer can be called and used from anywhere in React Root and also reslove #2298, #2529Issue
What changed?
The folder explorer that was dependent on
backend-ai-storage-listhas been separated and used insideLegacyFolderExplorer, which can be called and used from any part of react root.The API response to get files of a vfolder exists files(for legacy compatibility) and items. In explorer, I changed to using items.
Currently, you can use the folder ID passed as a query parameter by passing it as a prop.
How to test?
The
LegacyFolderExplorerprovides the same functionality as before. I'd appreciate it if you could check if there are any changes I missed compared to the existing modal.Why make this change?
To improve the usability and functionality of the modal and folder explorer components in the application.
Checklist: (if applicable)