feat: Folder Explorer in any page #2622
Merged
+94
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
yomybaby
changed the title
yomybaby
force-pushed
the
feature/folder-explorer-in-anypage
branch
from
c90a54f to
866933f
Compare
ironAiken2
changed the base branch from
feat/legacy-folder-explorer
to
graphite-base/2622
ironAiken2
force-pushed
the
feature/folder-explorer-in-anypage
branch
from
866933f to
ec8c1e5
Compare
ironAiken2
force-pushed
the
graphite-base/2622
branch
from
17cd1e4 to
cbf60b0
Compare
Merge activity
|
### TL;DR
The FolderExplorerOpener component has been added within a <Suspense> wrapper in the main layout. Additionally, there is refactoring of related components and hooks for optimized folder querying and a minor bug fix.
Now, Folder Explorer can be opened in any page without page transition.
### What changed?
- Wrapped <FolderExplorerOpener> with <Suspense fallback={null}> in the main layout.
- Refactored FolderExplorerOpener to use React.lazy for dynamic imports.
- Modified logic in LegacyFolderExplorer to leverage Relay for data fetching.
- Introduced a new utility function `formatToUUID` for string to UUID conversion.
- Updated pages and components to use the new FolderExplorerOpener logic accordingly.
- Removed redundant imports and code to ensure optimized performance and maintainability.
- Fixed navigation issue when closing the folder explorer.
### How to test?
1. Pull the latest changes and run the project.
2. Navigate through the application and ensure the folder explorer opens without issues.
3. Verify that the folder explorer properly fetches and displays folder names. (You can open folder by clicking folder name in `/data` page and endpoint detail page.
4. Test edge cases, such as closing the folder explorer and opening it with different folder IDs.
### Why make this change?
This change enhances the user experience by ensuring that the folder explorer is only loaded when needed, thus optimizing the application's performance. The refactoring also improves code maintainability and introduces utility methods for common tasks.
ironAiken2
force-pushed
the
feature/folder-explorer-in-anypage
branch
from
ec8c1e5 to
85da0f7
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.17% (+0% 🔼) |
184/5802 |
| 🔴 | Branches | 3.16% (+0% 🔼) |
123/3894 |
| 🔴 | Functions | 1.87% (+0% 🔼) |
36/1922 |
| 🔴 | Lines | 3.04% (+0% 🔼) |
173/5683 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | helper/index.tsx | 44.83% (-0.79% 🔻) |
43.33% (-0.59% 🔻) |
32.56% (-0.78% 🔻) |
45.1% (-0.9% 🔻) |
Test suite run success
64 tests passing in 6 suites.
Report generated by 🧪jest coverage report action from 85da0f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The FolderExplorerOpener component has been added within a wrapper in the main layout. Additionally, there is refactoring of related components and hooks for optimized folder querying and a minor bug fix.
Now, Folder Explorer can be opened in any page without page transition.
What changed?
formatToUUIDfor string to UUID conversion.How to test?
/datapage and endpoint detail page.Why make this change?
This change enhances the user experience by ensuring that the folder explorer is only loaded when needed, thus optimizing the application's performance. The refactoring also improves code maintainability and introduces utility methods for common tasks.