Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia/xid, hw slowdown, fuse, PCI): use common events store, simplify nvml poller initialization #336

Closed
wants to merge 1 commit into from

feat(nvidia/xid, hw slowdown, fuse, PCI): use common events store, si…

2ff3017
Select commit
Loading
Failed to load commit list.
Closed

feat(nvidia/xid, hw slowdown, fuse, PCI): use common events store, simplify nvml poller initialization #336

feat(nvidia/xid, hw slowdown, fuse, PCI): use common events store, si…
2ff3017
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 28, 2025 in 0s

20.68% (-0.79%) compared to 760ef3b

View this Pull Request on Codecov

20.68% (-0.79%) compared to 760ef3b

Details

Codecov Report

Attention: Patch coverage is 1.10497% with 179 lines in your changes missing coverage. Please review.

Project coverage is 20.68%. Comparing base (760ef3b) to head (2ff3017).

Files with missing lines Patch % Lines
internal/server/server.go 0.00% 37 Missing ⚠️
components/fuse/component_output.go 0.00% 32 Missing ⚠️
components/accelerator/nvidia/query/nvml/xid.go 0.00% 24 Missing ⚠️
components/diagnose/scan.go 0.00% 19 Missing ⚠️
components/fuse/component.go 0.00% 18 Missing ⚠️
components/accelerator/nvidia/query/nvml/nvml.go 0.00% 14 Missing ⚠️
...nents/accelerator/nvidia/query/nvidia_smi_query.go 0.00% 11 Missing ⚠️
components/accelerator/nvidia/query/query.go 0.00% 8 Missing ⚠️
...omponents/accelerator/nvidia/query/nvml/options.go 0.00% 4 Missing ⚠️
components/accelerator/nvidia/query/options.go 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   21.47%   20.68%   -0.79%     
==========================================
  Files         300      296       -4     
  Lines       27186    26530     -656     
==========================================
- Hits         5837     5489     -348     
+ Misses      20710    20424     -286     
+ Partials      639      617      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov