feat(nvidia/xid, hw slowdown, fuse, PCI): use common events store, simplify nvml poller initialization #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 21.47% 20.68% -0.79%
==========================================
Files 300 296 -4
Lines 27186 26530 -656
==========================================
- Hits 5837 5489 -348
+ Misses 20710 20424 -286
+ Partials 639 617 -22 ☔ View full report in Codecov by Sentry. |
gyuho
changed the title
gyuho
force-pushed
the
xid-from-nvml-to-events-db
branch
2 times, most recently
from
071b7d5 to
b2d5e17
Compare
gyuho
force-pushed
the
xid-from-nvml-to-events-db
branch
3 times, most recently
from
5baab10 to
35c443f
Compare
gyuho
changed the title
|
can we somehow split this into multiple PRs? |
gyuho
changed the title
…mplify nvml poller initialization Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
xid-from-nvml-to-events-db
branch
from
35c443f to
2ff3017
Compare
This was referenced Jan 28, 2025
gyuho
added a commit
that referenced
this pull request
Feb 3, 2025
c.f., #336 --------- Signed-off-by: Gyuho Lee <[email protected]>
gyuho
added a commit
that referenced
this pull request
Feb 3, 2025
c.f., #336 Signed-off-by: Gyuho Lee <[email protected]>
gyuho
added a commit
that referenced
this pull request
Feb 5, 2025
…sable NVML Xid event watcher in favor of "dmesg" watcher, deprecate redundant "error-xid-sxid" component (#343) - use common events DB for NVML-based xid watcher - disable NVML Xid event watcher in favor of "dmesg" watcher - deprecate redundant "error-xid-sxid" component c.f., #336 --------- Signed-off-by: Gyuho Lee <[email protected]>
gyuho
added a commit
that referenced
this pull request
Feb 6, 2025
c.f., #336 Requires #341. Tested <img width="1102" alt="Screenshot 2025-01-28 at 11 01 33 PM" src="https://github.com/user-attachments/assets/78c12072-42df-4c17-8789-2eb900577eb5" /> <img width="1537" alt="Screenshot 2025-01-28 at 11 01 45 PM" src="https://github.com/user-attachments/assets/9a520798-9aab-499f-9f03-433f1c8a9295" /> Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components/dbto persist NVML-originated Xid eventscomponents/dbto persist HW slowdown eventsShould be after #321