feat(nvidia): set default poller once with common db pkg #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 21.47% 21.46% -0.01%
==========================================
Files 300 300
Lines 27186 27100 -86
==========================================
- Hits 5837 5817 -20
+ Misses 20710 20641 -69
- Partials 639 642 +3 ☔ View full report in Codecov by Sentry. |
gyuho
force-pushed
the
simplify-nvml-initialization
branch
from
f450442 to
f77c452
Compare
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
simplify-nvml-initialization
branch
from
f77c452 to
c8b38f7
Compare
This was referenced Jan 28, 2025
|
tests? |
xiang90
reviewed
Jan 29, 2025
| nvidia_query.WithInfinibandClassDirectory(cfg.InfinibandClassDirectory), | ||
| ) | ||
| nvidia_query.GetDefaultPoller().Start(cctx, cfg.Query, Name) | ||
| if nvidia_query.GetDefaultPoller() != nil { |
There was a problem hiding this comment.
why do we need to check nil here but not in other components?
There was a problem hiding this comment.
xiang90
reviewed
Jan 29, 2025
| @@ -88,6 +89,9 @@ type instance struct { | |||
| // read-only database instance | |||
| dbRO *sql.DB | |||
|
|
|||
| xidEventsStore events_db.Store | |||
There was a problem hiding this comment.
rever this? let us do this in another pr
xiang90
reviewed
Jan 29, 2025
| @@ -88,6 +89,9 @@ type instance struct { | |||
| // read-only database instance | |||
| dbRO *sql.DB | |||
|
|
|||
| xidEventsStore events_db.Store | |||
| hwslowdownEventsStore events_db.Store | |||
xiang90
reviewed
Jan 29, 2025
| dbRW *sql.DB | ||
| dbRO *sql.DB | ||
|
|
||
| xidEventsStore events_db.Store |
|
let us only remove duplicate in this pr. add tests as well |
gyuho
added a commit
that referenced
this pull request
Jan 30, 2025
Cherry-picked from #341. Signed-off-by: Gyuho Lee <[email protected]>
gyuho
added a commit
that referenced
this pull request
Jan 31, 2025
Replace #341. Signed-off-by: Gyuho Lee <[email protected]>
|
This can be closed now in favor of #346. |
gyuho
added a commit
that referenced
this pull request
Feb 6, 2025
c.f., #336 Requires #341. Tested <img width="1102" alt="Screenshot 2025-01-28 at 11 01 33 PM" src="https://github.com/user-attachments/assets/78c12072-42df-4c17-8789-2eb900577eb5" /> <img width="1537" alt="Screenshot 2025-01-28 at 11 01 45 PM" src="https://github.com/user-attachments/assets/9a520798-9aab-499f-9f03-433f1c8a9295" /> Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f., #336