Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia/query): pass events store to shared poller #346

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 29, 2025

Replace #341.

@gyuho gyuho added this to the v0.4.0 milestone Jan 29, 2025
@gyuho gyuho self-assigned this Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 48 lines in your changes missing coverage. Please review.

Project coverage is 22.16%. Comparing base (c925761) to head (82f693d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/diagnose/scan.go 0.00% 22 Missing ⚠️
internal/server/server.go 0.00% 22 Missing ⚠️
components/accelerator/nvidia/query/query.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   21.88%   22.16%   +0.27%     
==========================================
  Files         300      300              
  Lines       27177    27233      +56     
==========================================
+ Hits         5947     6035      +88     
+ Misses      20602    20569      -33     
- Partials      628      629       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from set-nvidia-poller-once to main January 30, 2025 00:58
@gyuho gyuho force-pushed the pass-events-store branch 2 times, most recently from cfdace8 to 79f41e8 Compare January 30, 2025 03:50
@xiang90
Copy link
Contributor

xiang90 commented Jan 30, 2025

defer to @ccding / @cardyok

@gyuho gyuho force-pushed the pass-events-store branch from 79f41e8 to 82f693d Compare January 30, 2025 14:15
@gyuho gyuho merged commit 8838498 into main Jan 31, 2025
6 checks passed
@gyuho gyuho deleted the pass-events-store branch January 31, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants