Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia/hw-slowdown): use common db pkg for events #342

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 28, 2025

c.f., #336

Requires #341.

Tested

Screenshot 2025-01-28 at 11 01 33 PM Screenshot 2025-01-28 at 11 01 45 PM

@xiang90
Copy link
Contributor

xiang90 commented Jan 29, 2025

need to improve the test coverage to pass CI

@gyuho gyuho added the wip - do not merge working in progress label Jan 29, 2025
@gyuho gyuho changed the base branch from simplify-nvml-initialization to main January 31, 2025 04:24
@gyuho gyuho force-pushed the hw-slowdown-with-events-store branch 2 times, most recently from ae349e8 to fbff653 Compare January 31, 2025 05:51
@leptonai leptonai deleted a comment from codecov bot Jan 31, 2025
@gyuho gyuho force-pushed the hw-slowdown-with-events-store branch 3 times, most recently from 83847e6 to b862970 Compare January 31, 2025 07:06
@leptonai leptonai deleted a comment from codecov bot Jan 31, 2025
@gyuho gyuho removed the wip - do not merge working in progress label Jan 31, 2025
@gyuho gyuho force-pushed the hw-slowdown-with-events-store branch 8 times, most recently from 8e89b8d to 0272737 Compare February 4, 2025 23:33
@leptonai leptonai deleted a comment from codecov bot Feb 4, 2025
@gyuho gyuho force-pushed the hw-slowdown-with-events-store branch 2 times, most recently from c35513b to e201a17 Compare February 5, 2025 13:01
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.70423% with 35 lines in your changes missing coverage. Please review.

Project coverage is 22.56%. Comparing base (5d1d369) to head (efab191).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/accelerator/nvidia/query/nvml/nvml.go 0.00% 15 Missing ⚠️
...nents/accelerator/nvidia/query/nvidia_smi_query.go 52.00% 12 Missing ⚠️
components/accelerator/nvidia/query/query.go 0.00% 6 Missing ⚠️
...onents/accelerator/nvidia/hw-slowdown/component.go 80.00% 1 Missing ⚠️
internal/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   22.72%   22.56%   -0.16%     
==========================================
  Files         291      289       -2     
  Lines       26161    25869     -292     
==========================================
- Hits         5944     5838     -106     
+ Misses      19605    19430     -175     
+ Partials      612      601      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho force-pushed the hw-slowdown-with-events-store branch from e201a17 to efab191 Compare February 5, 2025 13:08
@gyuho gyuho merged commit 19e2296 into main Feb 6, 2025
5 of 6 checks passed
@gyuho gyuho deleted the hw-slowdown-with-events-store branch February 6, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants