fix: remove stream add/remove methods from connection interface #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should this be a breaking change? |
|
These methods are more prevalent than I thought. Going to close for now and maybe open this or another pr later. |
tabcat
force-pushed
the
connection-interface
branch
3 times, most recently
from
20c6680 to
1479ca3
Compare
|
I've converted it to a draft to avoid unnecessary notifications, feel free to re-open once you feel it ready for review. |
tabcat
force-pushed
the
connection-interface
branch
4 times, most recently
from
c9f0ab4 to
451cb19
Compare
tabcat
commented
Aug 7, 2023
tabcat
force-pushed
the
connection-interface
branch
from
451cb19 to
d8cee9d
Compare
remove (add|remove)Stream from connection interface remove (add|remove)Stream use from interface-compliance-tests remove (add|remove)Stream from libp2p connection methods remove (add|remove)Stream from libp2p upgrader methods remove ts-sinon dependency from interface-compliance-tests
tabcat
force-pushed
the
connection-interface
branch
from
d8cee9d to
1fe698b
Compare
maschad
changed the title
|
@maschad because methods were removed from a public API this is a breaking change. I have updated the issue description to use a commit override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix!: remove stream add/remove methods from connection interface
addStreamandremoveStreamare internal methods that do not need to be part of the public API.They are called internally on the connection implementation by the upgrader and do not need to be exposed to end users.
Closes #1855
BREAKING CHANGE: the addStream and removeStream methods have been removed from the connection interface
END_COMMIT_OVERRIDE