Revert "Use MLIR python detection environment (#8037)" #8038
Conversation
This reverts commit ab5dc6c.
|
Wheel builds are running here: https://github.com/llvm/circt/actions/runs/12661341210 Note that only Linux are expected to actually pass. |
|
I'm also looking into actually solving the root problem here, which is now affecting Linux and MacOS on main. I'd much rather keep the upstream helpers if we can. |
|
@cbalint13 @teqdruid do you guys mind if I merge this for now, since the wheel building succeeds. Was there a problem in the configuration that required #8037? It works for me locally and in the cibuildwheel environments. |
|
I do not mind. Sorry to break stuff.
…On Wed, Jan 8, 2025, 12:51 AM Mike Urbach ***@***.***> wrote:
@cbalint13 <https://github.com/cbalint13> @teqdruid
<https://github.com/teqdruid> do you guys mind if I merge this for now,
since the wheel building succeeds. Was there a problem in the configuration
that required #8037 <#8037>? It works
for me locally and in the cibuildwheel environments.
—
Reply to this email directly, view it on GitHub
<#8038 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALNXYH4DRZZ76SQFH6O27T2JS4HNAVCNFSM6AAAAABUYX56L6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZWHAYDONBZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It is fine, sorry to break stuff there, but I expected to see that failure on CI at very PR time. |
|
Alright, thanks folks, I will merge this for now. @cbalint13 if you want to try re-landing this, you can manually kick off this job on your PR to test the fix still works with the wheel building: https://github.com/llvm/circt/actions/workflows/uploadWheels.yml It should at least pass on Linux, since that should be the case after this revert PR merges. Since the failures I saw on Linux had the same signature as the already failing MacOS builds, it would be great if we could fix both at the same time. I'm still not sure why that is happening. |
This reverts commit ab5dc6c.