fix: datatable error rendering (#494)

lob · May 6, 2024 · c70c417 · c70c417
1 parent 320c159
commit c70c417
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v2.0.54
+
+- Fixes the `DataTable` error rendering
+
 ## v2.0.53
 
 - Fixes the `IconButton` test ID

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lob/ui-components",
-  "version": "2.0.53",
+  "version": "2.0.54",
   "engines": {
     "node": ">=20.2.0",
     "npm": ">=10.2.0"

diff --git a/src/components/DataTable/DataTable.vue b/src/components/DataTable/DataTable.vue
@@ -34,10 +34,11 @@
         : undefined
     "
   >
-    <!-- For some reason, if this is not explicit it fails. -->
-    <template v-if="loading !== true" #empty>
-      <Alert v-if="error" variant="error">{{ error }}</Alert>
-      <Alert v-else variant="info">No results</Alert>
+    <template #empty>
+      <template v-if="!loading">
+        <Alert v-if="error" variant="error">{{ error }}</Alert>
+        <Alert v-else variant="info">No results</Alert>
+      </template>
     </template>
 
     <template #loading>