Remove audit fields from Description download
#1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
sea-kelp
michplunkett
commented
Feb 4, 2025
Comment on lines
-163
to
-166
| "created_by": description.created_by, | ||
| "officer_id": description.officer_id, | ||
| "created_at": description.created_at, | ||
| "last_updated_at": description.last_updated_at, |
There was a problem hiding this comment.
Unless there's something I'm missing, these fields shouldn't be needed. They aren't included in any other _record_maker functions, so my guess is that we do not need to include them here.
abandoned-prototype
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removed audit fields from the
Descriptiondownload function. They leak user information and provide data that isn't particularly useful outside of internal auditing.Tests and Linting
developbranch.make create_db_diagramcommand.pytestpasses on my local development environment.pre-commitpasses on my local development environment.