Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit fields from Description download #1151

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Remove audit fields from Description download #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f894c
Update views.py
michplunkett Feb 4, 2025
5dfeaaf
Update downloads.py
michplunkett Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions OpenOversight/app/main/downloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,5 @@ def descriptions_record_maker(description: Description) -> _Record:
return {
"id": description.id,
"text_contents": description.text_contents,
"created_by": description.created_by,
"officer_id": description.officer_id,
"created_at": description.created_at,
"last_updated_at": description.last_updated_at,
Comment on lines -163 to -166
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's something I'm missing, these fields shouldn't be needed. They aren't included in any other _record_maker functions, so my guess is that we do not need to include them here.

}
3 changes: 0 additions & 3 deletions OpenOversight/app/main/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,10 +1746,7 @@ def download_dept_descriptions_csv(department_id: int):
field_names = [
"id",
"text_contents",
"created_by",
"officer_id",
"created_at",
"last_updated_at",
]

return make_downloadable_csv(
Expand Down