[PE-248] refactor: recents widget for scalability #6453
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/types/src/home.d.ts (1)
4-4: Consider renaming"all item"for clarity.
Using"all item"as a filter key is potentially confusing and inconsistent with the other keys. Consider using something like"all"or"all_items"to make the intent clearer.web/core/components/home/widgets/recents/index.tsx (1)
26-29: Use a distinct icon if needed for clarity.
Since"workspace_page"and"page"currently share the same icon, consider providing a unique icon if they differ semantically or visually. This helps users distinguish at a glance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/types/src/home.d.ts(2 hunks)web/core/components/home/widgets/recents/index.tsx(4 hunks)web/core/components/home/widgets/recents/page.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
packages/types/src/home.d.ts (1)
42-42: Addition of"workspace_page"looks good.
This addition is consistent with the PR objective of supporting workspace pages in the recent activity system.web/core/components/home/widgets/recents/index.tsx (1)
32-35: Prop extension approach is well done.
DefiningTRecentWidgetPropsto extendTHomeWidgetPropswith optional propertiespresetFilterandshowFilterSelectis a neat, flexible design.
| const pageDetails = activity.entity_data as TPageEntityData; | ||
| const ownerDetails = getUserDetails(pageDetails?.owned_by); | ||
| const pageLink = pageDetails.project_id | ||
| ? `/${workspaceSlug}/projects/${pageDetails.project_id}/pages/${pageDetails.id}` | ||
| : `/${workspaceSlug}/pages/${pageDetails.id}`; |
There was a problem hiding this comment.
💡 Codebase verification
Unsafe type casting confirmed for workspace pages
The TPageEntityData type incorrectly requires project_id and project_identifier fields, but workspace pages in the backend don't have project associations. This forced casting will cause runtime errors.
packages/types/src/home.d.ts: UpdateTPageEntityDatato make project fields optionalweb/core/components/home/widgets/recents/page.tsx: Add type guard before casting toTPageEntityData
🔗 Analysis chain
Confirm handling of workspace_page data.
When entity_name is "workspace_page", verify that the entity_data still conforms to TPageEntityData (e.g., having project_id, etc.). Otherwise, this forced casting may cause runtime issues.
Use this script to scan the codebase for "workspace_page" references, checking whether the entity data structure is consistent:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Look for workflow around "workspace_page" usage to ensure it always contains page fields
rg -A 5 '"workspace_page"'
Length of output: 2869
Script:
#!/bin/bash
# Look for TPageEntityData type definition and usage
ast-grep --pattern 'type TPageEntityData = {
$$$
}'
# Also search for any references to this type
rg "TPageEntityData"
Length of output: 889
Script:
#!/bin/bash
# Look for workspace page API handling and data structure
rg -A 5 "workspace_page.*data" --type ts
rg -A 5 "workspace_page.*response" --type ts
# Also check Python API implementation
rg -A 10 "workspace_page" --type py
Length of output: 7380
Description
This PR refactors the recents widgets component for scalability.
Type of Change
Summary by CodeRabbit
New Features
Improvements