Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3095] fix: recents widget title truncate #6512

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Jan 30, 2025

Description

This PR includes-

  1. Refactored the recent widget items to make proper use of the core ListItem component.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • New Features

    • Enhanced display of recent items (issues, pages, projects) with improved layout and dynamic title rendering
    • Added time-since-visited information to recent items
    • Refined visual presentation of recent activity widgets
  • Style

    • Updated component styling with more consistent and modern layout approaches
    • Improved text and icon styling across recent item components

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Jan 30, 2025
@aaryan610 aaryan610 added this to the v0.24.0 milestone Jan 30, 2025
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

The pull request introduces consistent updates to three recent activity components: RecentIssue, RecentPage, and RecentProject. The changes focus on refining the visual presentation and layout of these components by dynamically displaying names, restructuring title elements, and introducing an appendTitleElement to show activity timestamps. The modifications enhance the rendering of recent activities with a more streamlined and informative approach, maintaining the core functionality while improving the user interface.

Changes

File Change Summary
web/core/components/home/widgets/recents/issue.tsx - Updated title prop to display issueDetails?.name
- Restructured prependTitleElement to use grid layout
- Modified text color and styling classes
- Moved time display to appendTitleElement
web/core/components/home/widgets/recents/page.tsx - Updated title prop using getPageName function
- Simplified prependTitleElement layout
- Adjusted logo and icon size classes
- Moved page name to appendTitleElement
web/core/components/home/widgets/recents/project.tsx - Updated title prop to display projectDetails?.name
- Simplified prependTitleElement structure
- Added appendTitleElement with time since activity

Possibly related PRs

Suggested labels

🎨UI / UX

Suggested reviewers

  • gakshita
  • SatishGandham
  • rahulramesha

Poem

🐰 Widgets dancing, layout so bright
Recent items now shine with delight
Grid and flex, a rabbit's design
Timestamps sparkle, components align
Code poetry in motion, pure and clean! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58a4ca9 and b3e95a3.

📒 Files selected for processing (3)
  • web/core/components/home/widgets/recents/issue.tsx (3 hunks)
  • web/core/components/home/widgets/recents/page.tsx (1 hunks)
  • web/core/components/home/widgets/recents/project.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
web/core/components/home/widgets/recents/page.tsx (3)

40-40: LGTM! Title rendering improved.

The use of getPageName helper ensures consistent page title formatting and addresses the truncation issue.


42-56: LGTM! Layout structure enhanced.

The grid layout with consistent sizing (size-8, size-4) improves visual alignment and maintains consistency with other recent items.


57-61: LGTM! Timestamp display added.

The addition of timestamp display using calculateTimeAgo enhances the information hierarchy.

web/core/components/home/widgets/recents/project.tsx (3)

28-28: LGTM! Title rendering improved.

Direct use of projectDetails?.name is appropriate for project titles.


30-36: LGTM! Layout structure enhanced.

The grid layout maintains visual consistency with other recent items.


37-41: LGTM! Timestamp display added.

Consistent timestamp display implementation across components.

web/core/components/home/widgets/recents/issue.tsx (3)

33-33: LGTM! Title rendering improved.

Direct use of issueDetails?.name is appropriate for issue titles.


Line range hint 35-56: LGTM! Layout structure enhanced.

The conditional rendering between IssueIdentifier and fallback maintains proper visual hierarchy while ensuring consistent styling.


57-61: LGTM! Timestamp display added.

Consistent timestamp display implementation across components.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 changed the title [WEB-] fix: recents widget title truncate [WEB-3095] fix: recents widget title truncate Jan 30, 2025
@sriramveeraghanta sriramveeraghanta merged commit ff778b9 into preview Jan 30, 2025
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/dashboard-bugs branch January 30, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants