Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #3424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

taniaisthatyou
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the classes and methods according to the task requirements! 🎉 Your code meets all the core functionalities, and you've handled the logic for managing animals effectively. Keep up the good work, and continue to pay attention to the environment requirements like the use of crypto.randomUUID(). Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

constructor(name, health = 100) {
this.health = health;
this.name = name;
this.id = crypto.randomUUID();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of crypto.randomUUID() for generating a unique ID is correct, assuming the environment supports it. Ensure that the environment where this code runs has support for the crypto module and its randomUUID method.

}

class Carnivore extends Animal {
// write your code here
bite(target) {
if (target instanceof Herbivore && target.hidden === false) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition correctly checks if the target is an instance of Herbivore and is not hidden, which aligns with the task requirements. No changes needed here.

target.health -= 50;

if (target.health <= 0) {
Animal.alive = Animal.alive.filter((animal) => animal.id !== target.id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering the Animal.alive array to remove dead animals is correctly implemented here. This aligns with the task requirements and checklist, which allow filtering within the bite method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants