Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #3424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/herbivoresAndCarnivores.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,37 @@
'use strict';

class Animal {
// write your code here
static alive = [];

constructor(name, health = 100) {
this.health = health;
this.name = name;
this.id = crypto.randomUUID();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of crypto.randomUUID() for generating a unique ID is correct, assuming the environment supports it. Ensure that the environment where this code runs has support for the crypto module and its randomUUID method.

Animal.alive.push(this);
}
}

class Herbivore extends Animal {
// write your code here
constructor(name, health, hidden = false) {
super(name, health);
this.hidden = hidden;
}

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(target) {
if (target instanceof Herbivore && target.hidden === false) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition correctly checks if the target is an instance of Herbivore and is not hidden, which aligns with the task requirements. No changes needed here.

target.health -= 50;

if (target.health <= 0) {
Animal.alive = Animal.alive.filter((animal) => animal.id !== target.id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering the Animal.alive array to remove dead animals is correctly implemented here. This aligns with the task requirements and checklist, which allow filtering within the bite method.

}
}
}
}

module.exports = {
Expand Down